Re: [PATCH] Implement pci_set_dma_mask() in terms of the dma_ops

2007-12-17 Thread Christoph Hellwig
On Mon, Dec 17, 2007 at 05:35:53PM +1100, Michael Ellerman wrote: To save adding a hook to the dma mapping ops, pci-set_consistent_dma_mask() simply calls the dma_set_mask() hook and then copies the new mask into dev.coherenet_dma_mask. How is this supposed to work? There are various devices

Re: [PATCH] Implement pci_set_dma_mask() in terms of the dma_ops

2007-12-17 Thread Benjamin Herrenschmidt
On Mon, 2007-12-17 at 11:02 +0100, Christoph Hellwig wrote: On Mon, Dec 17, 2007 at 05:35:53PM +1100, Michael Ellerman wrote: To save adding a hook to the dma mapping ops, pci-set_consistent_dma_mask() simply calls the dma_set_mask() hook and then copies the new mask into

[PATCH] Implement pci_set_dma_mask() in terms of the dma_ops

2007-12-16 Thread Michael Ellerman
Powerpc currently doesn't implement pci_set_dma_mask(), which means drivers calling it will get the generic version in drivers/pci/pci.c. The Powerpc dma mapping ops include a dma_set_mask() hook, which luckily is not implemented by anyone - so there is no bug in the fact that the hook is