Re: [PATCH] KVM: PPC: Book3S: Remove redundant initialization of variable ret

[Paul Mackerras]

On Sat, Sep 19, 2020 at 03:12:30PM +0800, Jing Xiangfeng wrote:
> The variable ret is being initialized with '-ENOMEM' that is meaningless.
> So remove it.
> 
> Signed-off-by: Jing Xiangfeng 

Thanks, applied.

Paul.

Re: [PATCH] KVM: PPC: Book3S: Remove redundant initialization of variable ret

[Fabiano Rosas]

Jing Xiangfeng  writes:

> The variable ret is being initialized with '-ENOMEM' that is meaningless.
> So remove it.
>
> Signed-off-by: Jing Xiangfeng 

Reviewed-by: Fabiano Rosas 

> ---
>  arch/powerpc/kvm/book3s_64_vio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kvm/book3s_64_vio.c 
> b/arch/powerpc/kvm/book3s_64_vio.c
> index 1a529df0ab44..b277a75cd1be 100644
> --- a/arch/powerpc/kvm/book3s_64_vio.c
> +++ b/arch/powerpc/kvm/book3s_64_vio.c
> @@ -283,7 +283,7 @@ long kvm_vm_ioctl_create_spapr_tce(struct kvm *kvm,
>   struct kvmppc_spapr_tce_table *siter;
>   struct mm_struct *mm = kvm->mm;
>   unsigned long npages, size = args->size;
> - int ret = -ENOMEM;
> + int ret;
>
>   if (!args->size || args->page_shift < 12 || args->page_shift > 34 ||
>   (args->offset + args->size > (ULLONG_MAX >> args->page_shift)))

[PATCH] KVM: PPC: Book3S: Remove redundant initialization of variable ret

[Jing Xiangfeng]

The variable ret is being initialized with '-ENOMEM' that is meaningless.
So remove it.

Signed-off-by: Jing Xiangfeng 
---
 arch/powerpc/kvm/book3s_64_vio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c
index 1a529df0ab44..b277a75cd1be 100644
--- a/arch/powerpc/kvm/book3s_64_vio.c
+++ b/arch/powerpc/kvm/book3s_64_vio.c
@@ -283,7 +283,7 @@ long kvm_vm_ioctl_create_spapr_tce(struct kvm *kvm,
struct kvmppc_spapr_tce_table *siter;
struct mm_struct *mm = kvm->mm;
unsigned long npages, size = args->size;
-   int ret = -ENOMEM;
+   int ret;
 
if (!args->size || args->page_shift < 12 || args->page_shift > 34 ||
(args->offset + args->size > (ULLONG_MAX >> args->page_shift)))
-- 
2.17.1