Re: [PATCH] KVM: PPC: Book3S HV: Fix build failure without IOMMU support

2019-02-22 Thread Paul Mackerras
On Thu, Feb 21, 2019 at 02:28:48PM +1100, Jordan Niethe wrote:
> Currently trying to build without IOMMU support will fail:
> 
>   (.text+0x1380): undefined reference to `kvmppc_h_get_tce'
>   (.text+0x1384): undefined reference to `kvmppc_rm_h_put_tce'
>   (.text+0x149c): undefined reference to `kvmppc_rm_h_stuff_tce'
>   (.text+0x14a0): undefined reference to `kvmppc_rm_h_put_tce_indirect'
> 
> This happens because turning off IOMMU support will prevent
> book3s_64_vio_hv.c from being built because it is only built when
> SPAPR_TCE_IOMMU is set, which depends on IOMMU support.
> 
> Fix it using ifdefs for the undefined references.
> 
> Fixes: 76d837a4c0f9 ("KVM: PPC: Book3S PR: Don't include SPAPR TCE code on 
> non-pseries platforms")
> Signed-off-by: Jordan Niethe 

Thanks, applied to my kvm-ppc-next tree.

Paul.


[PATCH] KVM: PPC: Book3S HV: Fix build failure without IOMMU support

2019-02-20 Thread Jordan Niethe
Currently trying to build without IOMMU support will fail:

  (.text+0x1380): undefined reference to `kvmppc_h_get_tce'
  (.text+0x1384): undefined reference to `kvmppc_rm_h_put_tce'
  (.text+0x149c): undefined reference to `kvmppc_rm_h_stuff_tce'
  (.text+0x14a0): undefined reference to `kvmppc_rm_h_put_tce_indirect'

This happens because turning off IOMMU support will prevent
book3s_64_vio_hv.c from being built because it is only built when
SPAPR_TCE_IOMMU is set, which depends on IOMMU support.

Fix it using ifdefs for the undefined references.

Fixes: 76d837a4c0f9 ("KVM: PPC: Book3S PR: Don't include SPAPR TCE code on 
non-pseries platforms")
Signed-off-by: Jordan Niethe 
---
 arch/powerpc/kvm/book3s_hv.c|  2 ++
 arch/powerpc/kvm/book3s_hv_rmhandlers.S | 10 ++
 2 files changed, 12 insertions(+)

diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
index 5a066fc299e1..94e50438e6a2 100644
--- a/arch/powerpc/kvm/book3s_hv.c
+++ b/arch/powerpc/kvm/book3s_hv.c
@@ -937,6 +937,7 @@ int kvmppc_pseries_do_hcall(struct kvm_vcpu *vcpu)
ret = kvmppc_h_set_xdabr(vcpu, kvmppc_get_gpr(vcpu, 4),
kvmppc_get_gpr(vcpu, 5));
break;
+#ifdef CONFIG_SPAPR_TCE_IOMMU
case H_GET_TCE:
ret = kvmppc_h_get_tce(vcpu, kvmppc_get_gpr(vcpu, 4),
kvmppc_get_gpr(vcpu, 5));
@@ -966,6 +967,7 @@ int kvmppc_pseries_do_hcall(struct kvm_vcpu *vcpu)
if (ret == H_TOO_HARD)
return RESUME_HOST;
break;
+#endif
case H_RANDOM:
if (!powernv_get_random_long(>arch.regs.gpr[4]))
ret = H_HARDWARE;
diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S 
b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
index 9b8d50a7cbaf..541b121477e4 100644
--- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S
+++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
@@ -2264,8 +2264,13 @@ hcall_real_table:
.long   DOTSYM(kvmppc_h_clear_mod) - hcall_real_table
.long   DOTSYM(kvmppc_h_clear_ref) - hcall_real_table
.long   DOTSYM(kvmppc_h_protect) - hcall_real_table
+#ifdef CONFIG_SPAPR_TCE_IOMMU
.long   DOTSYM(kvmppc_h_get_tce) - hcall_real_table
.long   DOTSYM(kvmppc_rm_h_put_tce) - hcall_real_table
+#else
+   .long   0   /* 0x1c */
+   .long   0   /* 0x20 */
+#endif
.long   0   /* 0x24 - H_SET_SPRG0 */
.long   DOTSYM(kvmppc_h_set_dabr) - hcall_real_table
.long   0   /* 0x2c */
@@ -2343,8 +2348,13 @@ hcall_real_table:
.long   0   /* 0x12c */
.long   0   /* 0x130 */
.long   DOTSYM(kvmppc_h_set_xdabr) - hcall_real_table
+#ifdef CONFIG_SPAPR_TCE_IOMMU
.long   DOTSYM(kvmppc_rm_h_stuff_tce) - hcall_real_table
.long   DOTSYM(kvmppc_rm_h_put_tce_indirect) - hcall_real_table
+#else
+   .long   0   /* 0x138 */
+   .long   0   /* 0x13c */
+#endif
.long   0   /* 0x140 */
.long   0   /* 0x144 */
.long   0   /* 0x148 */
-- 
2.20.1