Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-28 Thread Tony Lindgren
* Geert Uytterhoeven [210128 09:32]: > It wasn't. The regression is that the driver no longer probes at first > try, because its dependencies are now probed later. The question is: > why are the dependencies now probed later? How to fix that? I'm afraid that may be unfixable.. It depends on

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-28 Thread Tony Lindgren
Hi, * Michael Walle [210125 19:52]: > Although I do have the changes for the builtin_platform_driver_probe() > ready, I don't think it makes much sense to send these unless we agree > on the increased memory footprint. While there are just a few > builtin_platform_driver_probe() and memory

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-28 Thread Geert Uytterhoeven
Hi Saravana, On Wed, Jan 27, 2021 at 6:11 PM Saravana Kannan wrote: > On Wed, Jan 27, 2021 at 8:56 AM Geert Uytterhoeven > wrote: > > On Wed, Jan 27, 2021 at 5:42 PM Saravana Kannan > > wrote: > > > On Tue, Jan 26, 2021 at 11:43 PM Geert Uytterhoeven > > > wrote: > > > > On Wed, Jan 27,

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-27 Thread Geert Uytterhoeven
Hi Saravana, On Wed, Jan 27, 2021 at 5:42 PM Saravana Kannan wrote: > On Tue, Jan 26, 2021 at 11:43 PM Geert Uytterhoeven > wrote: > > On Wed, Jan 27, 2021 at 1:44 AM Saravana Kannan > > wrote: > > > On Tue, Jan 26, 2021 at 12:50 AM Geert Uytterhoeven > > > wrote: > > > > On Mon, Jan 25,

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-26 Thread Geert Uytterhoeven
Hi Saravana, On Wed, Jan 27, 2021 at 1:44 AM Saravana Kannan wrote: > On Tue, Jan 26, 2021 at 12:50 AM Geert Uytterhoeven > wrote: > > On Mon, Jan 25, 2021 at 11:42 PM Saravana Kannan > > wrote: > > > On Mon, Jan 25, 2021 at 11:49 AM Michael Walle wrote: > > > > Am 2021-01-21 12:01, schrieb

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-26 Thread Geert Uytterhoeven
Hi Michael, On Tue, Jan 26, 2021 at 11:46 AM Michael Walle wrote: > Am 2021-01-26 11:02, schrieb Lorenzo Pieralisi: > > On Wed, Jan 20, 2021 at 11:52:46AM +0100, Michael Walle wrote: > >> fw_devlink will defer the probe until all suppliers are ready. We > >> can't > >> use

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-26 Thread Lorenzo Pieralisi
On Wed, 20 Jan 2021 11:52:46 +0100, Michael Walle wrote: > fw_devlink will defer the probe until all suppliers are ready. We can't > use builtin_platform_driver_probe() because it doesn't retry after probe > deferral. Convert it to builtin_platform_driver(). Applied to pci/dwc, thanks! [1/1]

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-26 Thread Michael Walle
Am 2021-01-26 11:02, schrieb Lorenzo Pieralisi: On Wed, Jan 20, 2021 at 11:52:46AM +0100, Michael Walle wrote: fw_devlink will defer the probe until all suppliers are ready. We can't use builtin_platform_driver_probe() because it doesn't retry after probe deferral. Convert it to

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-26 Thread Lorenzo Pieralisi
On Wed, Jan 20, 2021 at 11:52:46AM +0100, Michael Walle wrote: > fw_devlink will defer the probe until all suppliers are ready. We can't > use builtin_platform_driver_probe() because it doesn't retry after probe > deferral. Convert it to builtin_platform_driver(). > > Fixes: e590474768f1 ("driver

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-26 Thread Geert Uytterhoeven
Hi Saravana, On Mon, Jan 25, 2021 at 11:42 PM Saravana Kannan wrote: > On Mon, Jan 25, 2021 at 11:49 AM Michael Walle wrote: > > Am 2021-01-21 12:01, schrieb Geert Uytterhoeven: > > > On Thu, Jan 21, 2021 at 1:05 AM Saravana Kannan > > > wrote: > > >> On Wed, Jan 20, 2021 at 3:53 PM Michael

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-25 Thread Michael Walle
Am 2021-01-21 12:01, schrieb Geert Uytterhoeven: Hi Saravana, On Thu, Jan 21, 2021 at 1:05 AM Saravana Kannan wrote: On Wed, Jan 20, 2021 at 3:53 PM Michael Walle wrote: > Am 2021-01-20 20:47, schrieb Saravana Kannan: > > On Wed, Jan 20, 2021 at 11:28 AM Michael Walle > > wrote: > >> > >>

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-25 Thread Michael Walle
Am 2021-01-25 19:58, schrieb Saravana Kannan: On Mon, Jan 25, 2021 at 8:50 AM Lorenzo Pieralisi wrote: On Wed, Jan 20, 2021 at 08:28:36PM +0100, Michael Walle wrote: > [RESEND, fat-fingered the buttons of my mail client and converted > all CCs to BCCs :(] > > Am 2021-01-20 20:02, schrieb

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-25 Thread Lorenzo Pieralisi
On Wed, Jan 20, 2021 at 08:28:36PM +0100, Michael Walle wrote: > [RESEND, fat-fingered the buttons of my mail client and converted > all CCs to BCCs :(] > > Am 2021-01-20 20:02, schrieb Saravana Kannan: > > On Wed, Jan 20, 2021 at 6:24 AM Rob Herring wrote: > > > > > > On Wed, Jan 20, 2021 at

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-21 Thread Geert Uytterhoeven
Hi Saravana, On Thu, Jan 21, 2021 at 1:05 AM Saravana Kannan wrote: > On Wed, Jan 20, 2021 at 3:53 PM Michael Walle wrote: > > Am 2021-01-20 20:47, schrieb Saravana Kannan: > > > On Wed, Jan 20, 2021 at 11:28 AM Michael Walle > > > wrote: > > >> > > >> [RESEND, fat-fingered the buttons of my

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-20 Thread Michael Walle
Am 2021-01-20 20:47, schrieb Saravana Kannan: On Wed, Jan 20, 2021 at 11:28 AM Michael Walle wrote: [RESEND, fat-fingered the buttons of my mail client and converted all CCs to BCCs :(] Am 2021-01-20 20:02, schrieb Saravana Kannan: > On Wed, Jan 20, 2021 at 6:24 AM Rob Herring wrote: >> >>

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-20 Thread Michael Walle
Am 2021-01-20 20:02, schrieb Saravana Kannan: On Wed, Jan 20, 2021 at 6:24 AM Rob Herring wrote: On Wed, Jan 20, 2021 at 4:53 AM Michael Walle wrote: > > fw_devlink will defer the probe until all suppliers are ready. We can't > use builtin_platform_driver_probe() because it doesn't retry

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-20 Thread Michael Walle
[RESEND, fat-fingered the buttons of my mail client and converted all CCs to BCCs :(] Am 2021-01-20 20:02, schrieb Saravana Kannan: On Wed, Jan 20, 2021 at 6:24 AM Rob Herring wrote: On Wed, Jan 20, 2021 at 4:53 AM Michael Walle wrote: > > fw_devlink will defer the probe until all

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-20 Thread Greg Kroah-Hartman
On Wed, Jan 20, 2021 at 08:23:59AM -0600, Rob Herring wrote: > On Wed, Jan 20, 2021 at 4:53 AM Michael Walle wrote: > > > > fw_devlink will defer the probe until all suppliers are ready. We can't > > use builtin_platform_driver_probe() because it doesn't retry after probe > > deferral. Convert it

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-20 Thread Michael Walle
Am 2021-01-20 15:23, schrieb Rob Herring: On Wed, Jan 20, 2021 at 4:53 AM Michael Walle wrote: fw_devlink will defer the probe until all suppliers are ready. We can't use builtin_platform_driver_probe() because it doesn't retry after probe deferral. Convert it to builtin_platform_driver().

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-20 Thread Rob Herring
On Wed, Jan 20, 2021 at 4:53 AM Michael Walle wrote: > > fw_devlink will defer the probe until all suppliers are ready. We can't > use builtin_platform_driver_probe() because it doesn't retry after probe > deferral. Convert it to builtin_platform_driver(). If builtin_platform_driver_probe()

[PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-20 Thread Michael Walle
fw_devlink will defer the probe until all suppliers are ready. We can't use builtin_platform_driver_probe() because it doesn't retry after probe deferral. Convert it to builtin_platform_driver(). Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Signed-off-by: Michael Walle ---