Just a minor comment
On Tue, 2010-03-09 at 13:01 -0700, Jason Gunthorpe wrote:
@@ -703,7 +747,17 @@ static int __init init_tis(void)
return rc;
}
- return pnp_register_driver(tis_pnp_driver);
+#ifdef CONFIG_OF
+ rc = of_register_platform_driver(tis_of_driver);
On Thu, Mar 25, 2010 at 01:20:41AM -0300, Rajiv Andrade wrote:
Why not
+#ifdef CONFIG_OF
+ return of_register_platform_driver(tis_of_driver);
+#elif CONFIG_PNP
+ return pnp_register_driver(tis_pnp_driver);
+#endif
?
AFAIK they are not exclusive options? I can't imagine anyone
This provides an open firwmare driver binding for tpm_tis. OF
is useful on arches where PNP is not used.
Allow the tpm_tis driver to be selected if PNP or OF are compiled in.
Tested on a PPC405 with a winbond LPC TPM.
Signed-off-by: Jason Gunthorpe jguntho...@obsidianresearch.com
---
