Re: [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl()

On Mon, Feb 12, 2018 at 11:33 AM, Shilpasri G Bhat wrote: > Hi, > > On 02/12/2018 03:59 PM, Viresh Kumar wrote: >> On 12-02-18, 15:51, Shilpasri G Bhat wrote: >>> This patch fixes the below Coverity warning: >>> >>> *** CID 182816: Memory - illegal accesses

Re: [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl()

On Wed, Feb 21, 2018 at 2:13 PM, Michael Ellerman wrote: > "Rafael J. Wysocki" writes: > >> On Wed, Feb 21, 2018 at 6:54 AM, Viresh Kumar >> wrote: >>> On 21-02-18, 16:39, Michael Ellerman wrote: Viresh Kumar

Re: [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl()

"Rafael J. Wysocki" writes: > On Wed, Feb 21, 2018 at 6:54 AM, Viresh Kumar wrote: >> On 21-02-18, 16:39, Michael Ellerman wrote: >>> Viresh Kumar writes: >> >>> > AFAICT, you will get -1 here only if the freq table had no

Re: [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl()

On 21-02-18, 11:17, Rafael J. Wysocki wrote: > The driver is expected to call cpufreq_table_validate_and_show() at > ->init() time and fail ->init() if that fails. > > That's kind of fragile, because it depends on the driver to do the right > thing. That's exactly what I am trying to explore

Re: [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl()

On Wed, Feb 21, 2018 at 11:02 AM, Viresh Kumar wrote: > On 21-02-18, 10:27, Rafael J. Wysocki wrote: >> To be precise, ->init() should fail as that's where the table is >> created. The registration fails as a result then. >> >> But what if the bug is that ->init()

Re: [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl()

On 21-02-18, 10:27, Rafael J. Wysocki wrote: > To be precise, ->init() should fail as that's where the table is > created. The registration fails as a result then. > > But what if the bug is that ->init() doesn't fail when it should? > > I guess the core could double check the frequency table

Re: [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl()

On Wed, Feb 21, 2018 at 6:54 AM, Viresh Kumar wrote: > On 21-02-18, 16:39, Michael Ellerman wrote: >> Viresh Kumar writes: > >> > AFAICT, you will get -1 here only if the freq table had no valid >> > frequencies (or the freq table is empty). Why

Re: [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl()

On 21-02-18, 16:39, Michael Ellerman wrote: > Viresh Kumar writes: > > AFAICT, you will get -1 here only if the freq table had no valid > > frequencies (or the freq table is empty). Why would that happen ? > > Bugs? The cupfreq driver shouldn't have registered itself

Re: [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl()

Viresh Kumar writes: > On 12-02-18, 15:51, Shilpasri G Bhat wrote: >> This patch fixes the below Coverity warning: >> >> *** CID 182816: Memory - illegal accesses (NEGATIVE_RETURNS) >> /drivers/cpufreq/powernv-cpufreq.c: 1008 in powernv_fast_switch() >> 1002

Re: [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl()

On 12-02-18, 16:03, Shilpasri G Bhat wrote: > I agree too. There is no way we can get -1 with initialized cpu frequency > table. > We don't initialize powernv-cpufreq if we don't have valid CPU frequency > entries. Is there any other way to suppress the Coverity tool warning apart > from >

Re: [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl()

Hi, On 02/12/2018 03:59 PM, Viresh Kumar wrote: > On 12-02-18, 15:51, Shilpasri G Bhat wrote: >> This patch fixes the below Coverity warning: >> >> *** CID 182816: Memory - illegal accesses (NEGATIVE_RETURNS) >> /drivers/cpufreq/powernv-cpufreq.c: 1008 in powernv_fast_switch() >> 1002

Re: [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl()

On 12-02-18, 15:51, Shilpasri G Bhat wrote: > This patch fixes the below Coverity warning: > > *** CID 182816: Memory - illegal accesses (NEGATIVE_RETURNS) > /drivers/cpufreq/powernv-cpufreq.c: 1008 in powernv_fast_switch() > 1002 unsigned int

[PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl()

This patch fixes the below Coverity warning: *** CID 182816: Memory - illegal accesses (NEGATIVE_RETURNS) /drivers/cpufreq/powernv-cpufreq.c: 1008 in powernv_fast_switch() 1002unsigned int target_freq) 1003 { 1004int index; 1005