Re: [PATCH] crypto: caam/jr - Remove extra memory barrier during job ring dequeue

2019-05-09 Thread Michael Ellerman
Herbert Xu writes: > On Thu, May 02, 2019 at 11:08:55AM +, Horia Geanta wrote: >> >> + >> >> static inline void wr_reg32(void __iomem *reg, u32 data) >> >> { >> >> if (caam_little_end) >> > >> > This crashes on my p5020ds. Did you test on powerpc? >> > >> > # first bad commit: [bbfcac5ff

Re: [PATCH] crypto: caam/jr - Remove extra memory barrier during job ring dequeue

2019-05-08 Thread Herbert Xu
On Thu, May 02, 2019 at 11:08:55AM +, Horia Geanta wrote: > > >> + > >> static inline void wr_reg32(void __iomem *reg, u32 data) > >> { > >>if (caam_little_end) > > > > This crashes on my p5020ds. Did you test on powerpc? > > > > # first bad commit: [bbfcac5ff5f26aafa51935a62eb86b6eacfe

Re: [PATCH] crypto: caam/jr - Remove extra memory barrier during job ring dequeue

2019-05-02 Thread Horia Geanta
On 5/1/2019 8:49 AM, Michael Ellerman wrote: > Vakul Garg wrote: >> In function caam_jr_dequeue(), a full memory barrier is used before >> writing response job ring's register to signal removal of the completed >> job. Therefore for writing the register, we do not need another write >> memory barri

RE: [PATCH] crypto: caam/jr - Remove extra memory barrier during job ring dequeue

2019-05-01 Thread Michael Ellerman
Geanta ; >> linuxppc-dev@lists.ozlabs.org >> Subject: Re: [PATCH] crypto: caam/jr - Remove extra memory barrier during >> job ring dequeue >> >> Vakul Garg wrote: >> > In function caam_jr_dequeue(), a full memory barrier is used before >> > writing respo

RE: [PATCH] crypto: caam/jr - Remove extra memory barrier during job ring dequeue

2019-05-01 Thread Vakul Garg
Subject: Re: [PATCH] crypto: caam/jr - Remove extra memory barrier during > job ring dequeue > > Vakul Garg wrote: > > In function caam_jr_dequeue(), a full memory barrier is used before > > writing response job ring's register to signal removal of the > > comple

Re: [PATCH] crypto: caam/jr - Remove extra memory barrier during job ring dequeue

2019-04-30 Thread Michael Ellerman
Vakul Garg wrote: > In function caam_jr_dequeue(), a full memory barrier is used before > writing response job ring's register to signal removal of the completed > job. Therefore for writing the register, we do not need another write > memory barrier. Hence it is removed by replacing the call to wr