Re: [PATCH] cxl: Destroy cxl_adapter_idr on module_exit
Ian Munsie imun...@au1.ibm.com writes: Acked-by: Ian Munsie imun...@au1.ibm.com We are probably also missing an idr_destroy(afu-contexts_idr); in cxl_release_afu() as well if you wanted to send a patch for that. Cheers, -Ian Correct, patch is going out today. Thanks for the hint. -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
[PATCH] cxl: Destroy cxl_adapter_idr on module_exit
Destroy cxl_adapter_idr on module exit, reclaiming the allocated memory.
This was detected by the following semantic patch (written by Luis Rodriguez
mcg...@suse.com)
SmPL
@ defines_module_init @
declarer name module_init, module_exit;
declarer name DEFINE_IDR;
identifier init;
@@
module_init(init);
@ defines_module_exit @
identifier exit;
@@
module_exit(exit);
@ declares_idr depends on defines_module_init defines_module_exit @
identifier idr;
@@
DEFINE_IDR(idr);
@ on_exit_calls_destroy depends on declares_idr defines_module_exit @
identifier declares_idr.idr, defines_module_exit.exit;
@@
exit(void)
{
...
idr_destroy(idr);
...
}
@ missing_module_idr_destroy depends on declares_idr defines_module_exit
!on_exit_calls_destroy @
identifier declares_idr.idr, defines_module_exit.exit;
@@
exit(void)
{
...
+idr_destroy(idr);
}
/SmPL
Signed-off-by: Johannes Thumshirn jthumsh...@suse.de
---
drivers/misc/cxl/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/misc/cxl/main.c b/drivers/misc/cxl/main.c
index 833348e..4e58e0b 100644
--- a/drivers/misc/cxl/main.c
+++ b/drivers/misc/cxl/main.c
@@ -222,6 +222,7 @@ static void exit_cxl(void)
cxl_debugfs_exit();
cxl_file_exit();
unregister_cxl_calls(cxl_calls);
+ idr_destroy(cxl_adapter_idr);
}
module_init(init_cxl);
--
2.4.3
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH] cxl: Destroy cxl_adapter_idr on module_exit
Acked-by: Ian Munsie imun...@au1.ibm.com We are probably also missing an idr_destroy(afu-contexts_idr); in cxl_release_afu() as well if you wanted to send a patch for that. Cheers, -Ian ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
