Re: [PATCH] drivers: char: hw_random: printk replacement

2014-09-15 Thread Sudip Mukherjee
On Mon, Sep 15, 2014 at 07:41:23PM +0800, Herbert Xu wrote: On Thu, Aug 28, 2014 at 08:32:58PM +0530, Sudip Mukherjee wrote: as pr_* macros are more preffered over printk, so printk replaced with corresponding pr_* macros Signed-off-by: Sudip Mukherjee su...@vectorindia.org Your

Re: [PATCH] drivers: char: hw_random: printk replacement

2014-09-15 Thread Herbert Xu
On Thu, Aug 28, 2014 at 08:32:58PM +0530, Sudip Mukherjee wrote: as pr_* macros are more preffered over printk, so printk replaced with corresponding pr_* macros Signed-off-by: Sudip Mukherjee su...@vectorindia.org Your patch doesn't even build: CC [M] drivers/char/hw_random/intel-rng.o

Re: [PATCH] drivers: char: hw_random: printk replacement

2014-09-08 Thread Sudip Mukherjee
On Thu, Aug 28, 2014 at 08:32:58PM +0530, Sudip Mukherjee wrote: as pr_* macros are more preffered over printk, so printk replaced with corresponding pr_* macros Signed-off-by: Sudip Mukherjee su...@vectorindia.org --- The replacement was done by a bash script to avoid copy paste error.

Re: [PATCH] drivers: char: hw_random: printk replacement

2014-08-29 Thread Michael Ellerman
On Thu, 2014-08-28 at 20:32 +0530, Sudip Mukherjee wrote: as pr_* macros are more preffered over printk, so printk replaced with corresponding pr_* macros I suppose ... drivers/char/hw_random/pasemi-rng.c | 2 +- drivers/char/hw_random/pseries-rng.c | 2 +- These look OK to me. cheers

[PATCH] drivers: char: hw_random: printk replacement

2014-08-28 Thread Sudip Mukherjee
as pr_* macros are more preffered over printk, so printk replaced with corresponding pr_* macros Signed-off-by: Sudip Mukherjee su...@vectorindia.org --- The replacement was done by a bash script to avoid copy paste error. The script is as follows : OLD=printk(KERN_ERR \?