RE: [PATCH] fsldma: fsl_ioread64*() do not need lower_32_bits()

2020-08-31 Thread Leo Li
ev > ; dma ; Linux > Kernel Mailing List > Subject: Re: [PATCH] fsldma: fsl_ioread64*() do not need lower_32_bits() > > On Sat, Aug 29, 2020 at 1:40 PM Guenter Roeck wrote: > > > > Except for > > > > CHECK: spaces preferred around that '+' (ctx:Vx

Re: [PATCH] fsldma: fsl_ioread64*() do not need lower_32_bits()

2020-08-30 Thread Vinod Koul
Hi Linus, On 29-08-20, 14:20, Linus Torvalds wrote: > On Sat, Aug 29, 2020 at 1:40 PM Guenter Roeck wrote: > > > > Except for > > > > CHECK: spaces preferred around that '+' (ctx:VxV) > > #29: FILE: drivers/dma/fsldma.h:223: > > + u32 val_lo = in_be32((u32 __iomem *)addr+1); > > Added spac

Re: [PATCH] fsldma: fsl_ioread64*() do not need lower_32_bits()

2020-08-30 Thread Michael Ellerman
Linus Torvalds writes: > On Sat, Aug 29, 2020 at 1:40 PM Guenter Roeck wrote: >> >> Except for >> >> CHECK: spaces preferred around that '+' (ctx:VxV) >> #29: FILE: drivers/dma/fsldma.h:223: >> + u32 val_lo = in_be32((u32 __iomem *)addr+1); > > Added spaces. > >> I don't see anything wrong

Re: [PATCH] fsldma: fsl_ioread64*() do not need lower_32_bits()

2020-08-30 Thread Luc Van Oostenryck
On Sat, Aug 29, 2020 at 10:29:55AM -0700, Linus Torvalds wrote: > On Sat, Aug 29, 2020 at 5:46 AM Luc Van Oostenryck > wrote: > > > > But the pointer is already 32-bit, so simply cast the pointer to u32. > > Yeah, that code was completely pointless. If the pointer had actually > been 64-bit, the

Re: [PATCH] fsldma: fsl_ioread64*() do not need lower_32_bits()

2020-08-29 Thread Linus Torvalds
On Sat, Aug 29, 2020 at 1:40 PM Guenter Roeck wrote: > > Except for > > CHECK: spaces preferred around that '+' (ctx:VxV) > #29: FILE: drivers/dma/fsldma.h:223: > + u32 val_lo = in_be32((u32 __iomem *)addr+1); Added spaces. > I don't see anything wrong with it either, so > > Reviewed-by: G

Re: [PATCH] fsldma: fsl_ioread64*() do not need lower_32_bits()

2020-08-29 Thread Guenter Roeck
On 8/29/20 10:29 AM, Linus Torvalds wrote: > On Sat, Aug 29, 2020 at 5:46 AM Luc Van Oostenryck > wrote: >> >> But the pointer is already 32-bit, so simply cast the pointer to u32. > > Yeah, that code was completely pointless. If the pointer had actually > been 64-bit, the old code would have war

Re: [PATCH] fsldma: fsl_ioread64*() do not need lower_32_bits()

2020-08-29 Thread Linus Torvalds
On Sat, Aug 29, 2020 at 5:46 AM Luc Van Oostenryck wrote: > > But the pointer is already 32-bit, so simply cast the pointer to u32. Yeah, that code was completely pointless. If the pointer had actually been 64-bit, the old code would have warned too. The odd thing is that the fsl_iowrite64() fun

Re: [PATCH] fsldma: fsl_ioread64*() do not need lower_32_bits()

2020-08-29 Thread Christophe Leroy
Le 29/08/2020 à 17:05, Guenter Roeck a écrit : On Sat, Aug 29, 2020 at 02:45:38PM +0200, Luc Van Oostenryck wrote: For ppc32, the functions fsl_ioread64() & fsl_ioread64be() use lower_32_bits() as a fancy way to cast the pointer to u32 in order to do non-atomic 64-bit IO. But the pointer is

Re: [PATCH] fsldma: fsl_ioread64*() do not need lower_32_bits()

2020-08-29 Thread Guenter Roeck
On Sat, Aug 29, 2020 at 02:45:38PM +0200, Luc Van Oostenryck wrote: > For ppc32, the functions fsl_ioread64() & fsl_ioread64be() > use lower_32_bits() as a fancy way to cast the pointer to u32 > in order to do non-atomic 64-bit IO. > > But the pointer is already 32-bit, so simply cast the pointer

[PATCH] fsldma: fsl_ioread64*() do not need lower_32_bits()

2020-08-29 Thread Luc Van Oostenryck
For ppc32, the functions fsl_ioread64() & fsl_ioread64be() use lower_32_bits() as a fancy way to cast the pointer to u32 in order to do non-atomic 64-bit IO. But the pointer is already 32-bit, so simply cast the pointer to u32. This fixes a compile error introduced by ef91bb196b0d ("kernel.h: