On Thu, Jan 15, 2009 at 2:17 PM, Dan Williams wrote:
> Timur Tabi wrote:
>>
>> Peter Korsgaard wrote:
>>
>>> The only minor issues we have is the cosmetic problem of the driver
>>> printing NO_IRQ (E.G. this patch), and the driver calling
>>> free_irq(NO_IRQ) (E.G. the other patch I sent today) in
Timur Tabi wrote:
Peter Korsgaard wrote:
The only minor issues we have is the cosmetic problem of the driver
printing NO_IRQ (E.G. this patch), and the driver calling
free_irq(NO_IRQ) (E.G. the other patch I sent today) in the release
path.
Ok, I understand.
ACK on the patches.
Ok, Li Yan
Peter Korsgaard wrote:
> The only minor issues we have is the cosmetic problem of the driver
> printing NO_IRQ (E.G. this patch), and the driver calling
> free_irq(NO_IRQ) (E.G. the other patch I sent today) in the release
> path.
Ok, I understand.
ACK on the patches.
--
Timur Tabi
Linux kerne
> "Timur" == Timur Tabi writes:
Timur> Peter Korsgaard wrote:
>> Documentation/powerpc/dts-bindings/fsl/dma.txt and
>> The NO_IRQ check in fsldma.c:fsl_dma_chan_probe()
>>
>> And it makes sense, there's no per-channel DMAC interrupts on mpc83xx.
Timur> But the device trees do have IRQ
Peter Korsgaard wrote:
> Documentation/powerpc/dts-bindings/fsl/dma.txt and
> The NO_IRQ check in fsldma.c:fsl_dma_chan_probe()
>
> And it makes sense, there's no per-channel DMAC interrupts on mpc83xx.
But the device trees do have IRQs in the channels:
arch/powerpc/boot/dts/mpc836x_mds.dts:
d
> "Timur" == Timur Tabi writes:
Timur> Peter Korsgaard wrote:
>> Why? Does it buy us anything to request_irq again for each channel?
>>
>> Now we're at it, it seems like there's a check for != NO_IRQ missing
>> in fsl_dma_chan_remove().
Timur> If the device tree doesn't specify an int
Peter Korsgaard wrote:
> Why? Does it buy us anything to request_irq again for each channel?
>
> Now we're at it, it seems like there's a check for != NO_IRQ missing
> in fsl_dma_chan_remove().
If the device tree doesn't specify an interrupts property in the device channel,
then I think that's a
> "Timur" == Timur Tabi writes:
Timur> Peter Korsgaard wrote:
>> @@ -875,7 +875,8 @@ static int __devinit fsl_dma_chan_probe(struct
>> fsl_dma_device *fdev,
>> }
>>
>> dev_info(fdev->dev, "#%d (%s), irq %d\n", new_fsl_chan->id,
>> - compatible, new_fsl_chan-
Peter Korsgaard wrote:
> @@ -875,7 +875,8 @@ static int __devinit fsl_dma_chan_probe(struct
> fsl_dma_device *fdev,
> }
>
> dev_info(fdev->dev, "#%d (%s), irq %d\n", new_fsl_chan->id,
> - compatible, new_fsl_chan->irq);
> + compatible,
> +
The mpc83xx variant uses a shared IRQ for all channels, so the individual
channel nodes don't have an interrupt property. Fix the code to print the
controller IRQ instead if there isn't any for the channel.
Signed-off-by: Peter Korsgaard
---
drivers/dma/fsldma.c |3 ++-
1 files changed, 2 in
10 matches
Mail list logo
