Re: [PATCH] ibm_newemac: Don't call dev_mc_add() before device is registered

2008-08-27 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: We must not call dev_mc_add() from within our HW configure which happens before we initialize and register the netdev. Do it in open() instead. Thanks to Sebastian Siewior for tracking it down. Signed-off-by: Benjamin Herrenschmidt [EMAIL PROTECTED] --- This

[PATCH] ibm_newemac: Don't call dev_mc_add() before device is registered

2008-08-17 Thread Benjamin Herrenschmidt
We must not call dev_mc_add() from within our HW configure which happens before we initialize and register the netdev. Do it in open() instead. Thanks to Sebastian Siewior for tracking it down. Signed-off-by: Benjamin Herrenschmidt [EMAIL PROTECTED] --- This fixes an uninitialized spinlock