Re: [PATCH] kvm: powerpc: book3s: Disable preemption while accessing paca xics_phys filed

2017-03-29 Thread Michael Ellerman
Denis Kirjanov writes: > On Wednesday, March 29, 2017, Paul Mackerras wrote: > >> On Wed, Mar 29, 2017 at 12:07:03PM +1100, Michael Ellerman wrote: >> > Denis Kirjanov > writes: >> > >> [...] >> > > @@ -3930,7 +3934,11

Re: [PATCH] kvm: powerpc: book3s: Disable preemption while accessing paca xics_phys filed

2017-03-29 Thread Denis Kirjanov
On Wednesday, March 29, 2017, Paul Mackerras wrote: > On Wed, Mar 29, 2017 at 12:07:03PM +1100, Michael Ellerman wrote: > > Denis Kirjanov > writes: > > > [...] > > > @@ -3930,7 +3934,11 @@ static int kvmppc_book3s_init_hv(void) > > >

Re: [PATCH] kvm: powerpc: book3s: Disable preemption while accessing paca xics_phys filed

2017-03-29 Thread Paul Mackerras
On Wed, Mar 29, 2017 at 12:07:03PM +1100, Michael Ellerman wrote: > Denis Kirjanov writes: > [...] > > @@ -3930,7 +3934,11 @@ static int kvmppc_book3s_init_hv(void) > > * indirectly, via OPAL. > > */ > > #ifdef CONFIG_SMP > > - if

Re: [PATCH] kvm: powerpc: book3s: Disable preemption while accessing paca xics_phys filed

2017-03-29 Thread Denis Kirjanov
> Can you tell me what actual problem (other than the warning) this is > fixing? Since we're running with CONFIG_DEBUG_PREEMPT and CONFIG_SMP get_paca defined as: #define get_paca() ((void) debug_smp_processor_id(), local_paca) instead of direct access to r13 so it's possible that we're

Re: [PATCH] kvm: powerpc: book3s: Disable preemption while accessing paca xics_phys filed

2017-03-28 Thread Michael Ellerman
Denis Kirjanov writes: > With CONFIG_DEBUG_PREEMPT enabled we see the following trace: > > [ 129.314426] BUG: using smp_processor_id() in preemptible [] > code: modprobe/5459 > [ 129.314580] caller is .kvmppc_book3s_init_hv+0x184/0x350 [kvm_hv] > [ 129.314697]

[PATCH] kvm: powerpc: book3s: Disable preemption while accessing paca xics_phys filed

2017-03-27 Thread Denis Kirjanov
With CONFIG_DEBUG_PREEMPT enabled we see the following trace: [ 129.314426] BUG: using smp_processor_id() in preemptible [] code: modprobe/5459 [ 129.314580] caller is .kvmppc_book3s_init_hv+0x184/0x350 [kvm_hv] [ 129.314697] CPU: 11 PID: 5459 Comm: modprobe Not tainted