Re: [PATCH] leds: implement OpenFirmare GPIO LED driver

2008-07-17 Thread Anton Vorontsov
On Thu, Jul 17, 2008 at 07:59:03AM +0200, Segher Boessenkool wrote: diff --git a/Documentation/powerpc/dts-bindings/gpio/led.txt b/Documentation/powerpc/dts-bindings/gpio/led.txt new file mode 100644 index 000..7e9ce81 --- /dev/null +++ b/Documentation/powerpc/dts-bindings/gpio/led.txt

Re: [PATCH] leds: implement OpenFirmare GPIO LED driver

2008-07-17 Thread Sean MacLennan
On Thu, 17 Jul 2008 15:07:30 +0400 Anton Vorontsov [EMAIL PROTECTED] wrote: This is tricky question. Personally I place them inside the gpio controller node that is responsible for the LED. But I think placing the led nodes at top level would be also fine (maybe with leds { } node as a parent

Re: [PATCH] leds: implement OpenFirmare GPIO LED driver

2008-07-17 Thread Grant Likely
On Thu, Jul 17, 2008 at 03:07:30PM +0400, Anton Vorontsov wrote: On Thu, Jul 17, 2008 at 07:59:03AM +0200, Segher Boessenkool wrote: What would be the parent node of this, btw? This is tricky question. Personally I place them inside the gpio controller node that is responsible for the LED.

Re: [PATCH] leds: implement OpenFirmare GPIO LED driver

2008-07-17 Thread David Gibson
On Thu, Jul 17, 2008 at 09:07:15AM -0600, Grant Likely wrote: On Thu, Jul 17, 2008 at 03:07:30PM +0400, Anton Vorontsov wrote: On Thu, Jul 17, 2008 at 07:59:03AM +0200, Segher Boessenkool wrote: What would be the parent node of this, btw? This is tricky question. Personally I place them

Re: [PATCH] leds: implement OpenFirmare GPIO LED driver

2008-07-17 Thread Grant Likely
On Fri, Jul 18, 2008 at 01:35:12PM +1000, David Gibson wrote: This brings us back to the issue we also have with DCR controlled devices. Possibly we should have two ways of representing these connections: for pure GPIO-only or DCR-only devices, they appear under the relevant controller with

Re: [PATCH] leds: implement OpenFirmare GPIO LED driver

2008-07-16 Thread Segher Boessenkool
diff --git a/Documentation/powerpc/dts-bindings/gpio/led.txt b/Documentation/powerpc/dts-bindings/gpio/led.txt new file mode 100644 index 000..7e9ce81 --- /dev/null +++ b/Documentation/powerpc/dts-bindings/gpio/led.txt @@ -0,0 +1,15 @@ +LED connected to GPIO + +Required properties: +-