Re: [PATCH] powerpc/85xx: Fix SMP compile error and allow NULL for smp_ops

2009-09-08 Thread Kumar Gala
On Sep 8, 2009, at 4:31 PM, Benjamin Herrenschmidt wrote: On Tue, 2009-09-08 at 14:21 -0500, Kumar Gala wrote: struct smp_ops_t smp_85xx_ops = { + .message_pass = NULL, + .probe = NULL, .kick_cpu = smp_85xx_kick_cpu, + .setup_cpu = NULL, }; Why explicitely setting

Re: [PATCH] powerpc/85xx: Fix SMP compile error and allow NULL for smp_ops

2009-09-08 Thread Benjamin Herrenschmidt
On Tue, 2009-09-08 at 14:21 -0500, Kumar Gala wrote: > > struct smp_ops_t smp_85xx_ops = { > + .message_pass = NULL, > + .probe = NULL, > .kick_cpu = smp_85xx_kick_cpu, > + .setup_cpu = NULL, > }; Why explicitely setting those to NULL ? Cheers, Ben. > -static int __init sm

[PATCH] powerpc/85xx: Fix SMP compile error and allow NULL for smp_ops

2009-09-08 Thread Kumar Gala
The following commit introduced a compile error since it removed the implementation of smp_85xx_basic_setup: commit 77c0a700c1c292edafa11c1e52821ce4636f81b0 Author: Benjamin Herrenschmidt Date: Fri Aug 28 14:25:04 2009 +1000 powerpc: Properly start decrementer on BookE secondary CPUs Make