Re: [PATCH] powerpc/kernel: improve FP and vector registers restoration

2017-06-04 Thread Michael Ellerman
Breno Leitao writes: > Currently tsk->thread->load_vec and load_fp are not initialized during a > task creation, which set garbage to these variables (non-zero value). > > These variables will be checked later at restore_math() to validate if the > FP and vectors are being

Re: [PATCH] powerpc/kernel: improve FP and vector registers restoration

2017-06-04 Thread Breno Leitao
On Sun, Jun 04, 2017 at 11:38:14AM +1000, Anton Blanchard wrote: > On Sat, 3 Jun 2017 19:42:14 -0300 > Breno Leitao wrote: > > > Hi Anton, > > > > On Sat, Jun 03, 2017 at 08:04:11AM +1000, Anton Blanchard wrote: > > > Hi Breno, > > > > > > > Currently tsk->thread->load_vec

Re: [PATCH] powerpc/kernel: improve FP and vector registers restoration

2017-06-03 Thread Anton Blanchard
On Sat, 3 Jun 2017 19:42:14 -0300 Breno Leitao wrote: > Hi Anton, > > On Sat, Jun 03, 2017 at 08:04:11AM +1000, Anton Blanchard wrote: > > Hi Breno, > > > > > Currently tsk->thread->load_vec and load_fp are not initialized > > > during a task creation, which set garbage to

Re: [PATCH] powerpc/kernel: improve FP and vector registers restoration

2017-06-03 Thread Breno Leitao
Hi Anton, On Sat, Jun 03, 2017 at 08:04:11AM +1000, Anton Blanchard wrote: > Hi Breno, > > > Currently tsk->thread->load_vec and load_fp are not initialized > > during a task creation, which set garbage to these variables > > (non-zero value). > > Nice catch! It seems like we should zero

[PATCH] powerpc/kernel: improve FP and vector registers restoration

2017-06-02 Thread Breno Leitao
Currently tsk->thread->load_vec and load_fp are not initialized during a task creation, which set garbage to these variables (non-zero value). These variables will be checked later at restore_math() to validate if the FP and vectors are being utilized. Since these values might be non-zero, the

Re: [PATCH] powerpc/kernel: improve FP and vector registers restoration

2017-06-02 Thread Anton Blanchard
Hi Breno, > Currently tsk->thread->load_vec and load_fp are not initialized > during a task creation, which set garbage to these variables > (non-zero value). Nice catch! It seems like we should zero load_tm too though? Acked-by: Anton Blanchard Anton > These variables will

[PATCH] powerpc/kernel: improve FP and vector registers restoration

2017-06-02 Thread Breno Leitao
Currently tsk->thread->load_vec and load_fp are not initialized during a task creation, which set garbage to these variables (non-zero value). These variables will be checked later at restore_math() to validate if the FP and vectors are being utilized. Since these values might be non-zero, the