Re: [PATCH] powerpc/kvm: Fall through switch case explicitly
On Mon, 2019-07-29 at 05:55:36 UTC, Santosh Sivaraj wrote: > Implicit fallthrough warning was enabled globally which broke > the build. Make it explicit with a `fall through` comment. > > Signed-off-by: Santosh Sivaraj > Reviewed-by: Stephen Rothwell > Reviewed-by: Gustavo A. R. Silva Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/705d0abbcc7adf04743d04ea8754acbcdf21c326 cheers
Re: [PATCH] powerpc/kvm: Fall through switch case explicitly
Hi Gustavo, On Mon, 29 Jul 2019 22:57:05 -0500 "Gustavo A. R. Silva" wrote: > > On 7/29/19 10:50 PM, Stephen Rothwell wrote: > > > > I am assuming that Michael Ellerman will take it into his fixes tree > > and send it to Lunis fairly soon as it actually breaks some powerpc > > builds. > > Yeah. It seems that now that -Wimplicit-fallthrough has been globally enabled, > that's the case for all of these patches. Only some of them cause failures (as opposed to warnings) .. in this case because arch/powerpc is built with -Werror. -- Cheers, Stephen Rothwell pgpeSfCEAY6SV.pgp Description: OpenPGP digital signature
Re: [PATCH] powerpc/kvm: Fall through switch case explicitly
On 7/29/19 10:50 PM, Stephen Rothwell wrote: > Hi Gustavo, > > On Mon, 29 Jul 2019 22:30:34 -0500 "Gustavo A. R. Silva" > wrote: >> >> If no one takes it by tomorrow, I'll take it in my tree. > > I am assuming that Michael Ellerman will take it into his fixes tree > and send it to Lunis fairly soon as it actually breaks some powerpc > builds. > Yeah. It seems that now that -Wimplicit-fallthrough has been globally enabled, that's the case for all of these patches. Anyway, I can always take them in my tree if needed. Thanks -- Gustavo
Re: [PATCH] powerpc/kvm: Fall through switch case explicitly
Hi Gustavo, On Mon, 29 Jul 2019 22:30:34 -0500 "Gustavo A. R. Silva" wrote: > > If no one takes it by tomorrow, I'll take it in my tree. I am assuming that Michael Ellerman will take it into his fixes tree and send it to Lunis fairly soon as it actually breaks some powerpc builds. -- Cheers, Stephen Rothwell pgp3n8MKI4xi5.pgp Description: OpenPGP digital signature
Re: [PATCH] powerpc/kvm: Fall through switch case explicitly
Hi Stephen, On 7/29/19 10:18 PM, Stephen Rothwell wrote: > Hi all, > > On Mon, 29 Jul 2019 18:45:40 -0500 "Gustavo A. R. Silva" > wrote: >> >> On 7/29/19 3:16 AM, Stephen Rothwell wrote: >>> >>> On Mon, 29 Jul 2019 11:25:36 +0530 Santosh Sivaraj >>> wrote: Implicit fallthrough warning was enabled globally which broke the build. Make it explicit with a `fall through` comment. Signed-off-by: Santosh Sivaraj >> >> Reviewed-by: Gustavo A. R. Silva >> >> Thanks! >> -- >> Gustavo >> --- arch/powerpc/kvm/book3s_32_mmu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/kvm/book3s_32_mmu.c b/arch/powerpc/kvm/book3s_32_mmu.c index 653936177857..18f244aad7aa 100644 --- a/arch/powerpc/kvm/book3s_32_mmu.c +++ b/arch/powerpc/kvm/book3s_32_mmu.c @@ -239,6 +239,7 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct kvm_vcpu *vcpu, gva_t eaddr, case 2: case 6: pte->may_write = true; + /* fall through */ case 3: case 5: case 7: -- 2.20.1 >>> >>> Thanks >>> >>> Reviewed-by: Stephen Rothwell >>> >>> This only shows up as a warning in a powerpc allyesconfig build. >>> > > I will apply this to linux-next today (and keep it until it turns up in > some other tree). > If no one takes it by tomorrow, I'll take it in my tree. Thanks! -- Gustavo
Re: [PATCH] powerpc/kvm: Fall through switch case explicitly
Hi all, On Mon, 29 Jul 2019 18:45:40 -0500 "Gustavo A. R. Silva" wrote: > > On 7/29/19 3:16 AM, Stephen Rothwell wrote: > > > > On Mon, 29 Jul 2019 11:25:36 +0530 Santosh Sivaraj > > wrote: > >> > >> Implicit fallthrough warning was enabled globally which broke > >> the build. Make it explicit with a `fall through` comment. > >> > >> Signed-off-by: Santosh Sivaraj > > Reviewed-by: Gustavo A. R. Silva > > Thanks! > -- > Gustavo > > >> --- > >> arch/powerpc/kvm/book3s_32_mmu.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/arch/powerpc/kvm/book3s_32_mmu.c > >> b/arch/powerpc/kvm/book3s_32_mmu.c > >> index 653936177857..18f244aad7aa 100644 > >> --- a/arch/powerpc/kvm/book3s_32_mmu.c > >> +++ b/arch/powerpc/kvm/book3s_32_mmu.c > >> @@ -239,6 +239,7 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct > >> kvm_vcpu *vcpu, gva_t eaddr, > >>case 2: > >>case 6: > >>pte->may_write = true; > >> + /* fall through */ > >>case 3: > >>case 5: > >>case 7: > >> -- > >> 2.20.1 > >> > > > > Thanks > > > > Reviewed-by: Stephen Rothwell > > > > This only shows up as a warning in a powerpc allyesconfig build. > > I will apply this to linux-next today (and keep it until it turns up in some other tree). -- Cheers, Stephen Rothwell pgpLJv2H7Q2Aw.pgp Description: OpenPGP digital signature
Re: [PATCH] powerpc/kvm: Fall through switch case explicitly
On 7/29/19 3:16 AM, Stephen Rothwell wrote: > Hi Santosh, > > On Mon, 29 Jul 2019 11:25:36 +0530 Santosh Sivaraj wrote: >> >> Implicit fallthrough warning was enabled globally which broke >> the build. Make it explicit with a `fall through` comment. >> >> Signed-off-by: Santosh Sivaraj Reviewed-by: Gustavo A. R. Silva Thanks! -- Gustavo >> --- >> arch/powerpc/kvm/book3s_32_mmu.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/powerpc/kvm/book3s_32_mmu.c >> b/arch/powerpc/kvm/book3s_32_mmu.c >> index 653936177857..18f244aad7aa 100644 >> --- a/arch/powerpc/kvm/book3s_32_mmu.c >> +++ b/arch/powerpc/kvm/book3s_32_mmu.c >> @@ -239,6 +239,7 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct >> kvm_vcpu *vcpu, gva_t eaddr, >> case 2: >> case 6: >> pte->may_write = true; >> +/* fall through */ >> case 3: >> case 5: >> case 7: >> -- >> 2.20.1 >> > > Thanks > > Reviewed-by: Stephen Rothwell > > This only shows up as a warning in a powerpc allyesconfig build. >
Re: [PATCH] powerpc/kvm: Fall through switch case explicitly
Hi Santosh, On Mon, 29 Jul 2019 11:25:36 +0530 Santosh Sivaraj wrote: > > Implicit fallthrough warning was enabled globally which broke > the build. Make it explicit with a `fall through` comment. > > Signed-off-by: Santosh Sivaraj > --- > arch/powerpc/kvm/book3s_32_mmu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/kvm/book3s_32_mmu.c > b/arch/powerpc/kvm/book3s_32_mmu.c > index 653936177857..18f244aad7aa 100644 > --- a/arch/powerpc/kvm/book3s_32_mmu.c > +++ b/arch/powerpc/kvm/book3s_32_mmu.c > @@ -239,6 +239,7 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct kvm_vcpu > *vcpu, gva_t eaddr, > case 2: > case 6: > pte->may_write = true; > + /* fall through */ > case 3: > case 5: > case 7: > -- > 2.20.1 > Thanks Reviewed-by: Stephen Rothwell This only shows up as a warning in a powerpc allyesconfig build. -- Cheers, Stephen Rothwell pgpbXnSZyNvg8.pgp Description: OpenPGP digital signature
[PATCH] powerpc/kvm: Fall through switch case explicitly
Implicit fallthrough warning was enabled globally which broke the build. Make it explicit with a `fall through` comment. Signed-off-by: Santosh Sivaraj --- arch/powerpc/kvm/book3s_32_mmu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/kvm/book3s_32_mmu.c b/arch/powerpc/kvm/book3s_32_mmu.c index 653936177857..18f244aad7aa 100644 --- a/arch/powerpc/kvm/book3s_32_mmu.c +++ b/arch/powerpc/kvm/book3s_32_mmu.c @@ -239,6 +239,7 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct kvm_vcpu *vcpu, gva_t eaddr, case 2: case 6: pte->may_write = true; + /* fall through */ case 3: case 5: case 7: -- 2.20.1
