Re: [PATCH] powerpc/mm: Fix mapped range information print during boot

[Anshuman Khandual]

On 05/03/2017 03:02 PM, Michael Ellerman wrote:
> Anshuman Khandual  writes:
> 
>> This is a trivial fix patch regarding mapped ranges in radix MMU
>> environment during boot. No functional change.
>>
>> Before the patch:
>>
>> $dmesg | grep Mapped
>> [0.00] Mapped range 0x0 - 0x20 with 0x4000
>> [0.00] Mapped range 0x2000 - 0x2020 with 0x4000
>>
>> After the patch:
>>
>> $dmesg | grep Mapped
>> [0.00] Mapped range 0x - 0x0020 with 
>> 1024 MB
>> [0.00] Mapped range 0x2000 - 0x2020 with 
>> 1024 MB
> 
> It's a bit better, how about this instead?

Yeah this is better, I had tried to fix it in place.

Re: [PATCH] powerpc/mm: Fix mapped range information print during boot

[Michael Ellerman]

Anshuman Khandual  writes:

> This is a trivial fix patch regarding mapped ranges in radix MMU
> environment during boot. No functional change.
>
> Before the patch:
>
> $dmesg | grep Mapped
> [0.00] Mapped range 0x0 - 0x20 with 0x4000
> [0.00] Mapped range 0x2000 - 0x2020 with 0x4000
>
> After the patch:
>
> $dmesg | grep Mapped
> [0.00] Mapped range 0x - 0x0020 with 1024 
> MB
> [0.00] Mapped range 0x2000 - 0x2020 with 1024 
> MB

It's a bit better, how about this instead?

diff --git a/arch/powerpc/mm/pgtable-radix.c b/arch/powerpc/mm/pgtable-radix.c
index c28165d8970b..519cfef569d1 100644
--- a/arch/powerpc/mm/pgtable-radix.c
+++ b/arch/powerpc/mm/pgtable-radix.c
@@ -8,9 +8,14 @@
  * as published by the Free Software Foundation; either version
  * 2 of the License, or (at your option) any later version.
  */
+
+#define pr_fmt(fmt) "radix-mmu: " fmt
+
+#include 
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -112,10 +117,14 @@ static inline void __meminit print_mapping(unsigned long 
start,
   unsigned long end,
   unsigned long size)
 {
+   char buf[10];
+
if (end <= start)
return;
 
-   pr_info("Mapped range 0x%lx - 0x%lx with 0x%lx\n", start, end, size);
+   string_get_size(size, 1, STRING_UNITS_2, buf, sizeof(buf));
+
+   pr_info("Mapped 0x%016lx-0x%016lx with %s pages\n", start, end, buf);
 }
 
 static int __meminit create_physical_mapping(unsigned long start,


cheers

[PATCH] powerpc/mm: Fix mapped range information print during boot

[Anshuman Khandual]

This is a trivial fix patch regarding mapped ranges in radix MMU
environment during boot. No functional change.

Before the patch:

$dmesg | grep Mapped
[0.00] Mapped range 0x0 - 0x20 with 0x4000
[0.00] Mapped range 0x2000 - 0x2020 with 0x4000

After the patch:

$dmesg | grep Mapped
[0.00] Mapped range 0x - 0x0020 with 1024 MB
[0.00] Mapped range 0x2000 - 0x2020 with 1024 MB

Signed-off-by: Anshuman Khandual 
---
 arch/powerpc/mm/pgtable-radix.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/mm/pgtable-radix.c b/arch/powerpc/mm/pgtable-radix.c
index c28165d..802ead4 100644
--- a/arch/powerpc/mm/pgtable-radix.c
+++ b/arch/powerpc/mm/pgtable-radix.c
@@ -115,7 +115,8 @@ static inline void __meminit print_mapping(unsigned long 
start,
if (end <= start)
return;
 
-   pr_info("Mapped range 0x%lx - 0x%lx with 0x%lx\n", start, end, size);
+   pr_info("Mapped range 0x%016lx - 0x%016lx with %lu MB\n",
+   start, end, (unsigned long) (size >> 20));
 }
 
 static int __meminit create_physical_mapping(unsigned long start,
-- 
2.9.3