Re: [PATCH] powerpc/nvram: Replace kmalloc with kzalloc in the error message

2020-06-03 Thread Dan Carpenter
On Wed, Jun 03, 2020 at 09:37:18PM +1000, Michael Ellerman wrote: > Dan Carpenter writes: > > On Tue, Jun 02, 2020 at 09:23:57PM +1000, Michael Ellerman wrote: > >> Markus Elfring writes: > >> Please just remove the message instead, it's a tiny allocation that's > >> unlikely to ever fa

Re: [PATCH] powerpc/nvram: Replace kmalloc with kzalloc in the error message

2020-06-03 Thread Michael Ellerman
Dan Carpenter writes: > On Tue, Jun 02, 2020 at 09:23:57PM +1000, Michael Ellerman wrote: >> Markus Elfring writes: >> Please just remove the message instead, it's a tiny allocation that's >> unlikely to ever fail, and the caller will print an error anyway. >> >>> >> >>> How do you thin

Re: [PATCH] powerpc/nvram: Replace kmalloc with kzalloc in the error message

2020-06-02 Thread Dan Carpenter
On Tue, Jun 02, 2020 at 09:23:57PM +1000, Michael Ellerman wrote: > Markus Elfring writes: > Please just remove the message instead, it's a tiny allocation that's > unlikely to ever fail, and the caller will print an error anyway. > >>> > >>> How do you think about to take another look a

Re: [PATCH] powerpc/nvram: Replace kmalloc with kzalloc in the error message

2020-06-02 Thread Michael Ellerman
Markus Elfring writes: Please just remove the message instead, it's a tiny allocation that's unlikely to ever fail, and the caller will print an error anyway. >>> >>> How do you think about to take another look at a previous update suggestion >>> like the following? >>> >>> powerpc/nvram

Re: [PATCH] powerpc/nvram: Replace kmalloc with kzalloc in the error message

2020-06-01 Thread Markus Elfring
>>> Please just remove the message instead, it's a tiny allocation that's >>> unlikely to ever fail, and the caller will print an error anyway. >> >> How do you think about to take another look at a previous update suggestion >> like the following? >> >> powerpc/nvram: Delete three error messages f

Re: [PATCH] powerpc/nvram: Replace kmalloc with kzalloc in the error message

2020-06-01 Thread Michael Ellerman
Markus Elfring writes: >> Please just remove the message instead, it's a tiny allocation that's >> unlikely to ever fail, and the caller will print an error anyway. > > How do you think about to take another look at a previous update suggestion > like the following? > > powerpc/nvram: Delete three

Re: [PATCH] powerpc/nvram: Replace kmalloc with kzalloc in the error message

2020-05-29 Thread Markus Elfring
> Please just remove the message instead, it's a tiny allocation that's > unlikely to ever fail, and the caller will print an error anyway. How do you think about to take another look at a previous update suggestion like the following? powerpc/nvram: Delete three error messages for a failed memor

Re: [PATCH] powerpc/nvram: Replace kmalloc with kzalloc in the error message

2020-05-28 Thread Michael Ellerman
Yi Wang writes: > From: Liao Pingfang > > Use kzalloc instead of kmalloc in the error message according to > the previous kzalloc() call. Please just remove the message instead, it's a tiny allocation that's unlikely to ever fail, and the caller will print an error anyway. cheers > diff --git

[PATCH] powerpc/nvram: Replace kmalloc with kzalloc in the error message

2020-05-28 Thread Yi Wang
From: Liao Pingfang Use kzalloc instead of kmalloc in the error message according to the previous kzalloc() call. Signed-off-by: Liao Pingfang --- arch/powerpc/kernel/nvram_64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/nvram_64.c b/arch/powerpc/ke