Re: [PATCH] powerpc/powernv/npu: Fix reference leak

2019-06-03 Thread Michael Ellerman
On Fri, 2019-04-19 at 15:34:13 UTC, Greg Kurz wrote: > Since 902bdc57451c, get_pci_dev() calls pci_get_domain_bus_and_slot(). This > has the effect of incrementing the reference count of the PCI device, as > explained in drivers/pci/search.c: > > * Given a PCI domain, bus, and slot/function numbe

Re: [PATCH] powerpc/powernv/npu: Fix reference leak

2019-05-14 Thread Greg Kurz
On Tue, 14 May 2019 21:13:40 +1000 Michael Ellerman wrote: > Greg Kurz writes: > > Michael, > > > > Any comments on this patch ? Should I repost with a shorter comment > > as suggested by Alexey ? > > No the longer comment seems fine to me. > > I'm not a big fan of the patch, it's basically

Re: [PATCH] powerpc/powernv/npu: Fix reference leak

2019-05-14 Thread Michael Ellerman
Greg Kurz writes: > Michael, > > Any comments on this patch ? Should I repost with a shorter comment > as suggested by Alexey ? No the longer comment seems fine to me. I'm not a big fan of the patch, it's basically a hack :) But for a backportable fix I guess it is OK. I would be happier thoug

Re: [PATCH] powerpc/powernv/npu: Fix reference leak

2019-05-13 Thread Greg Kurz
Michael, Any comments on this patch ? Should I repost with a shorter comment as suggested by Alexey ? Cheers, -- Greg On Mon, 29 Apr 2019 12:36:59 +0200 Greg Kurz wrote: > On Mon, 29 Apr 2019 16:01:29 +1000 > Alexey Kardashevskiy wrote: > > > On 20/04/2019 01:34, Greg Kurz wrote: > > > Si

Re: [PATCH] powerpc/powernv/npu: Fix reference leak

2019-04-29 Thread Greg Kurz
On Mon, 29 Apr 2019 16:01:29 +1000 Alexey Kardashevskiy wrote: > On 20/04/2019 01:34, Greg Kurz wrote: > > Since 902bdc57451c, get_pci_dev() calls pci_get_domain_bus_and_slot(). This > > has the effect of incrementing the reference count of the PCI device, as > > explained in drivers/pci/search.c

Re: [PATCH] powerpc/powernv/npu: Fix reference leak

2019-04-28 Thread Alexey Kardashevskiy
On 20/04/2019 01:34, Greg Kurz wrote: > Since 902bdc57451c, get_pci_dev() calls pci_get_domain_bus_and_slot(). This > has the effect of incrementing the reference count of the PCI device, as > explained in drivers/pci/search.c: > > * Given a PCI domain, bus, and slot/function number, the desir

[PATCH] powerpc/powernv/npu: Fix reference leak

2019-04-19 Thread Greg Kurz
Since 902bdc57451c, get_pci_dev() calls pci_get_domain_bus_and_slot(). This has the effect of incrementing the reference count of the PCI device, as explained in drivers/pci/search.c: * Given a PCI domain, bus, and slot/function number, the desired PCI * device is located in the list of PCI devi