Re: [PATCH] powerpc/pseries: avoid blocking in irq when queuing hotplug events

2019-06-30 Thread Michael Ellerman
On Tue, 2019-05-28 at 23:28:01 UTC, Nathan Lynch wrote: > A couple of bugs in queue_hotplug_event(): > > 1. Unchecked kmalloc result which could lead to an oops. > 2. Use of GFP_KERNEL allocations in interrupt context (this code's >only caller is ras_hotplug_interrupt()). > > Use kmemdup to

[PATCH] powerpc/pseries: avoid blocking in irq when queuing hotplug events

2019-05-28 Thread Nathan Lynch
A couple of bugs in queue_hotplug_event(): 1. Unchecked kmalloc result which could lead to an oops. 2. Use of GFP_KERNEL allocations in interrupt context (this code's only caller is ras_hotplug_interrupt()). Use kmemdup to avoid open-coding the allocation+copy and check for failure; use