Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-06-18 Thread Arnd Bergmann
On Monday 15 June 2009, Timur Tabi wrote: On Mon, Jun 15, 2009 at 2:50 AM, Michael Ellermanmich...@ellerman.id.au wrote: arch/powerpc/platforms/chrp/setup.c:378: error: the frame size of 1040 bytes is larger than 1024 bytes What's so bad about a frame size larger than 1024? It's not

Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-06-15 Thread Michael Ellerman
On Wed, 2009-06-10 at 16:48 +1000, Michael Ellerman wrote: Add the option to build the code under arch/powerpc with -Werror. The intention is to make it harder for people to inadvertantly introduce warnings in the arch/powerpc code. It needs to be configurable so that if a warning is

Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-06-15 Thread Benjamin Herrenschmidt
Currently this appears to break only one of the defconfigs, chrp32. http://kisskb.ellerman.id.au/kisskb/head/1907/ And that's a legitimate error AFAICT: arch/powerpc/platforms/chrp/setup.c:378: error: the frame size of 1040 bytes is larger than 1024 bytes From: 367 void 368

Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-06-15 Thread Michael Ellerman
On Mon, 2009-06-15 at 19:40 +1000, Benjamin Herrenschmidt wrote: Currently this appears to break only one of the defconfigs, chrp32. http://kisskb.ellerman.id.au/kisskb/head/1907/ And that's a legitimate error AFAICT: arch/powerpc/platforms/chrp/setup.c:378: error: the frame size

Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-06-15 Thread Timur Tabi
On Mon, Jun 15, 2009 at 2:50 AM, Michael Ellermanmich...@ellerman.id.au wrote: arch/powerpc/platforms/chrp/setup.c:378: error: the frame size of 1040 bytes is larger than 1024 bytes What's so bad about a frame size larger than 1024? -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-06-15 Thread Benjamin Herrenschmidt
Yeah that occured to me, someone with a chrp machine would need to test it, do we have one? Yup, I think we do. I'll check that when I'm in the office. We can have a closer look tomorrow. In any case, stack alloc for that is indeed fishy. The obvious patch to make it static doesn't fly

[PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-06-10 Thread Michael Ellerman
Add the option to build the code under arch/powerpc with -Werror. The intention is to make it harder for people to inadvertantly introduce warnings in the arch/powerpc code. It needs to be configurable so that if a warning is introduced, people can easily work around it while it's being fixed.

Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-04-07 Thread Geert Uytterhoeven
On Mon, 6 Apr 2009, Olof Johansson wrote: On Tue, Apr 07, 2009 at 12:00:41PM +1000, Michael Ellerman wrote: Add an option, on by default, to build all code under arch/powerpc with -Werror, which causes gcc to treat warnings as errors. The intention is to make it harder for people to

Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-04-07 Thread Stephen Rothwell
On Tue, 7 Apr 2009 09:41:38 +0200 (CEST) Geert Uytterhoeven geert.uytterhoe...@sonycom.com wrote: On Mon, 6 Apr 2009, Olof Johansson wrote: This is really only beneficial if various people build for powerpc often enough. If major subsystem maintainers aren't going to hit the errors

Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-04-07 Thread Olof Johansson
On Tue, Apr 07, 2009 at 03:01:33AM +, Michael Ellerman wrote: On Mon, 2009-04-06 at 21:27 -0500, Olof Johansson wrote: On Tue, Apr 07, 2009 at 12:00:41PM +1000, Michael Ellerman wrote: Add an option, on by default, to build all code under arch/powerpc with -Werror, which causes gcc to

Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-04-07 Thread Kumar Gala
On Apr 6, 2009, at 9:00 PM, Michael Ellerman wrote: Add an option, on by default, to build all code under arch/powerpc with -Werror, which causes gcc to treat warnings as errors. The intention is to make it harder for people to inadvertantly introduce errors in the arch/powerpc code. It

Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-04-06 Thread Kumar Gala
On Apr 5, 2009, at 11:18 PM, Michael Ellerman wrote: diff --git a/arch/powerpc/math-emu/Makefile b/arch/powerpc/math-emu/ Makefile index 0c16ab9..dcb2148 100644 --- a/arch/powerpc/math-emu/Makefile +++ b/arch/powerpc/math-emu/Makefile @@ -1,4 +1,8 @@ +ifeq ($(CONFIG_PPC_WERROR),y)

[PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-04-06 Thread Michael Ellerman
Add an option, on by default, to build all code under arch/powerpc with -Werror, which causes gcc to treat warnings as errors. The intention is to make it harder for people to inadvertantly introduce errors in the arch/powerpc code. It needs to be configurable so that if a warning is introduced,

Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-04-06 Thread Olof Johansson
On Tue, Apr 07, 2009 at 12:00:41PM +1000, Michael Ellerman wrote: Add an option, on by default, to build all code under arch/powerpc with -Werror, which causes gcc to treat warnings as errors. The intention is to make it harder for people to inadvertantly introduce errors in the arch/powerpc

Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-04-06 Thread David Miller
From: Olof Johansson o...@lixom.net Date: Mon, 6 Apr 2009 21:27:43 -0500 On Tue, Apr 07, 2009 at 12:00:41PM +1000, Michael Ellerman wrote: Add an option, on by default, to build all code under arch/powerpc with -Werror, which causes gcc to treat warnings as errors. The intention is to make

Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-04-06 Thread Olof Johansson
On Mon, Apr 06, 2009 at 07:28:30PM -0700, David Miller wrote: From: Olof Johansson o...@lixom.net Date: Mon, 6 Apr 2009 21:27:43 -0500 On Tue, Apr 07, 2009 at 12:00:41PM +1000, Michael Ellerman wrote: Add an option, on by default, to build all code under arch/powerpc with -Werror, which

Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-04-06 Thread Michael Ellerman
On Mon, 2009-04-06 at 21:27 -0500, Olof Johansson wrote: On Tue, Apr 07, 2009 at 12:00:41PM +1000, Michael Ellerman wrote: Add an option, on by default, to build all code under arch/powerpc with -Werror, which causes gcc to treat warnings as errors. The intention is to make it harder for

[PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-04-05 Thread Michael Ellerman
Add an option, on by default, to build all code under arch/powerpc with -Werror, which causes gcc to treat warnings as errors. The intention is to make it harder for people to inadvertantly introduce errors in the arch/powerpc code. It needs to be configurable so that if a warning is introduced,