Re: [PATCH] powerpc: EOI spurious irqs during boot so they can be reenabled later

2008-08-06 Thread miltonm
- Original Message Follows - From: Michael Ellerman [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: Paul Mackerras [EMAIL PROTECTED], linuxppc-dev@ozlabs.org, Segher Boessenkool [EMAIL PROTECTED] Subject: Re: [PATCH] powerpc: EOI spurious irqs during boot so they can be reenabled later Date

[PATCH] powerpc: EOI spurious irqs during boot so they can be reenabled later

2008-08-05 Thread Michael Ellerman
In the xics code, if we receive an irq during boot that hasn't been setup yet - ie. we have no reverse mapping for it - we mask the irq so we don't hear from it again. Later on if someone request_irq()'s that irq, we'll unmask it but it will still never fire. This is because we never EOI'ed the

Re: [PATCH] powerpc: EOI spurious irqs during boot so they can be reenabled later

2008-08-05 Thread Segher Boessenkool
So when we receive a spurious irq, EOI it, and then mask it. What happens when a new IRQ arrives on the interrupt controller between these EOI and mask calls? Should you instead first mask it, and only then EOI it? Or doesn't that work on XICS? Segher

Re: [PATCH] powerpc: EOI spurious irqs during boot so they can be reenabled later

2008-08-05 Thread Michael Ellerman
On Tue, 2008-08-05 at 18:48 +0200, Segher Boessenkool wrote: So when we receive a spurious irq, EOI it, and then mask it. What happens when a new IRQ arrives on the interrupt controller between these EOI and mask calls? Should you instead first mask it, and only then EOI it? Or doesn't

[PATCH] powerpc: EOI spurious irqs during boot so they can be reenabled later

2008-08-05 Thread Michael Ellerman
In the xics code, if we receive an irq during boot that hasn't been setup yet - ie. we have no reverse mapping for it - we mask the irq so we don't hear from it again. Later on if someone request_irq()'s that irq, we'll unmask it but it will still never fire. This is because we never EOI'ed the

Re: [PATCH] powerpc: EOI spurious irqs during boot so they can be reenabled later

2008-08-05 Thread miltonm
- Original Message Follows - From: Michael Ellerman [EMAIL PROTECTED] To: Paul Mackerras [EMAIL PROTECTED] Cc: linuxppc-dev@ozlabs.org, Milton Miller [EMAIL PROTECTED], Segher Boessenkool [EMAIL PROTECTED] Subject: [PATCH] powerpc: EOI spurious irqs during boot so they can be reenabled

Re: [PATCH] powerpc: EOI spurious irqs during boot so they can be reenabled later

2008-08-05 Thread Michael Ellerman
: Michael Ellerman [EMAIL PROTECTED] Date: Tue, 5 Aug 2008 22:34:48 +1000 Subject: [PATCH] powerpc: EOI spurious irqs during boot so they can be reenabled later In the xics code, if we receive an irq during boot that hasn't been setup yet - ie. we have no reverse mapping for it - we mask the irq so