Re: [Cbe-oss-dev] [PATCH] powerpc: PPC_CELL_NATIVE should select PCI

2009-04-06 Thread Geert Uytterhoeven
On Mon, 6 Apr 2009, Paul Mackerras wrote: > Arnd Bergmann writes: > > On Thursday 02 April 2009, Geert Uytterhoeven wrote: > > > | arch/powerpc/platforms/built-in.o:(.toc1+0x4e8): undefined reference to > > > `pci_io_base' > > > > > > due to arch/powerpc/platforms/cell/io-workarounds.c. I guess t

Re: [PATCH] powerpc: PPC_CELL_NATIVE should select PCI

2009-04-05 Thread Paul Mackerras
Arnd Bergmann writes: > On Thursday 02 April 2009, Geert Uytterhoeven wrote: > > | arch/powerpc/platforms/built-in.o:(.toc1+0x4e8): undefined reference to > > `pci_io_base' > > > > due to arch/powerpc/platforms/cell/io-workarounds.c. I guess this file > > shouldn't be built when CONFIG_PCI=n? >

Re: [PATCH] powerpc: PPC_CELL_NATIVE should select PCI

2009-04-02 Thread Benjamin Krill
* Arnd Bergmann | 2009-04-02 15:15:11 [+0200]: >BenK, can you try Geert's patch on QPACE? Successfully tested on QPACE. Acked-by: Benjamin Krill ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: PPC_CELL_NATIVE should select PCI

2009-04-02 Thread Arnd Bergmann
On Thursday 02 April 2009, Geert Uytterhoeven wrote: > | arch/powerpc/platforms/built-in.o:(.toc1+0x4e8): undefined reference to > `pci_io_base' > > due to arch/powerpc/platforms/cell/io-workarounds.c. I guess this file > shouldn't be built when CONFIG_PCI=n? Right, the I/O workarounds are speci

Re: [PATCH] powerpc: PPC_CELL_NATIVE should select PCI

2009-04-02 Thread Geert Uytterhoeven
On Wed, 1 Apr 2009, Benjamin Herrenschmidt wrote: > On Wed, 2009-04-01 at 12:45 +0200, Arnd Bergmann wrote: > > On Wednesday 01 April 2009, Benjamin Herrenschmidt wrote: > > > On Wed, 2009-04-01 at 11:42 +0200, Geert Uytterhoeven wrote: > > > > PPC_CELL_NATIVE selects PPC_OF_PLATFORM_PCI, but not t

Re: [PATCH] powerpc: PPC_CELL_NATIVE should select PCI

2009-04-01 Thread Arnd Bergmann
On Wednesday 01 April 2009, Benjamin Herrenschmidt wrote: > On Wed, 2009-04-01 at 12:45 +0200, Arnd Bergmann wrote: > > No, QPACE does not have any PCI devices whatsoever. > > so something like select PPC_OF_PLATFORM_PCI if PCI would work you > think ? Yes, that sounds good. Arnd <>< _

Re: [PATCH] powerpc: PPC_CELL_NATIVE should select PCI

2009-04-01 Thread Benjamin Herrenschmidt
On Wed, 2009-04-01 at 12:45 +0200, Arnd Bergmann wrote: > On Wednesday 01 April 2009, Benjamin Herrenschmidt wrote: > > On Wed, 2009-04-01 at 11:42 +0200, Geert Uytterhoeven wrote: > > > PPC_CELL_NATIVE selects PPC_OF_PLATFORM_PCI, but not the underlying PCI, > > > causing build failures if PCI is

Re: [PATCH] powerpc: PPC_CELL_NATIVE should select PCI

2009-04-01 Thread Arnd Bergmann
On Wednesday 01 April 2009, Benjamin Herrenschmidt wrote: > On Wed, 2009-04-01 at 11:42 +0200, Geert Uytterhoeven wrote: > > PPC_CELL_NATIVE selects PPC_OF_PLATFORM_PCI, but not the underlying PCI, > > causing build failures if PCI is not set. > > Maybe it should only select it if PCI is enabled ?

Re: [PATCH] powerpc: PPC_CELL_NATIVE should select PCI

2009-04-01 Thread Benjamin Herrenschmidt
On Wed, 2009-04-01 at 11:42 +0200, Geert Uytterhoeven wrote: > PPC_CELL_NATIVE selects PPC_OF_PLATFORM_PCI, but not the underlying PCI, > causing build failures if PCI is not set. Maybe it should only select it if PCI is enabled ? Is qpace using PCI ? Cheers, Ben. > Signed-off-by: Geert Uytterho

[PATCH] powerpc: PPC_CELL_NATIVE should select PCI

2009-04-01 Thread Geert Uytterhoeven
PPC_CELL_NATIVE selects PPC_OF_PLATFORM_PCI, but not the underlying PCI, causing build failures if PCI is not set. Signed-off-by: Geert Uytterhoeven --- arch/powerpc/platforms/cell/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/platforms/cell/Kconfi