Re: [PATCH] soc: fsl/qe: fix gpio save_regs functions

[Linus Walleij]

On Tue, Sep 6, 2016 at 12:52 AM, Christophe Leroy
 wrote:

> of_mm_gpiochip_add_data() calls mm_gc->save_regs() before
> setting the data. Therefore ->save_regs() cannot use
> gpiochip_get_data()
>
> An Oops is encountered without this fix.
>
> fixes: 1e714e54b5ca5 ("powerpc: qe_lib-gpio: use gpiochip data pointer")
> Signed-off-by: Christophe Leroy 
> Cc: 

Aha sorry for my regular screwups. :(
Reviewed-by: Linus Walleij 

Yours,
Linus Walleij

[PATCH] soc: fsl/qe: fix gpio save_regs functions

[Christophe Leroy]

of_mm_gpiochip_add_data() calls mm_gc->save_regs() before
setting the data. Therefore ->save_regs() cannot use
gpiochip_get_data()

An Oops is encountered without this fix.

fixes: 1e714e54b5ca5 ("powerpc: qe_lib-gpio: use gpiochip data pointer")
Signed-off-by: Christophe Leroy 
Cc: 
---
 drivers/soc/fsl/qe/gpio.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/fsl/qe/gpio.c b/drivers/soc/fsl/qe/gpio.c
index 333eb22..0aaf429 100644
--- a/drivers/soc/fsl/qe/gpio.c
+++ b/drivers/soc/fsl/qe/gpio.c
@@ -41,7 +41,8 @@ struct qe_gpio_chip {
 
 static void qe_gpio_save_regs(struct of_mm_gpio_chip *mm_gc)
 {
-   struct qe_gpio_chip *qe_gc = gpiochip_get_data(_gc->gc);
+   struct qe_gpio_chip *qe_gc =
+   container_of(mm_gc, struct qe_gpio_chip, mm_gc);
struct qe_pio_regs __iomem *regs = mm_gc->regs;
 
qe_gc->cpdata = in_be32(>cpdata);
-- 
2.1.0