Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context

2009-04-21 Thread David Miller
From: Anton Vorontsov Date: Sat, 18 Apr 2009 02:03:48 +0400 > This will make the system alot more responsive while ping flooding the > ucc_geth ethernet interface. > > Also set NAPI weight to 64 as this is a common value. > > Signed-off-by: Joakim Tjernlund > Signed-off-by: Anton Vorontsov A

[PATCH] ucc_geth: Move freeing of TX packets to NAPI context

2009-04-17 Thread Anton Vorontsov
From: Joakim Tjernlund This will make the system alot more responsive while ping flooding the ucc_geth ethernet interface. Also set NAPI weight to 64 as this is a common value. Signed-off-by: Joakim Tjernlund Signed-off-by: Anton Vorontsov --- drivers/net/ucc_geth.c | 31 +++---

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-30 Thread David Miller
From: Joakim Tjernlund Date: Mon, 30 Mar 2009 12:01:33 +0200 > I don't know. But the question you should ask is: Does the networking > code promise this now and for the future? If not, you should > fix the driver not to relay on netif_queue_stopped() here. Stop this nonsense talk. If the driver

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-30 Thread Li Yang
23b1f37f4818c0fd0217b93eb38ab6564840 Mon Sep 17 > 00:00:00 >> >> > 2001 >> >> >> > From: Joakim Tjernlund >> >> >> > Date: Tue, 24 Mar 2009 10:19:27 +0100 >> >> >> > Subject: [PATCH] ucc_geth: Move

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-30 Thread Joakim Tjernlund
> Anton Vorontsov wrote on 25/03/2009 > > 15:25:40: > >> >> On Wed, Mar 25, 2009 at 02:30:49PM +0100, Joakim Tjernlund wrote: > >> >> > >>From 1c2f23b1f37f4818c0fd0217b93eb38ab6564840 Mon Sep 17 00:00:00 > >> > 2001 > >> >> >

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-30 Thread Li Yang
5, 2009 at 02:30:49PM +0100, Joakim Tjernlund wrote: >> >> > >>From 1c2f23b1f37f4818c0fd0217b93eb38ab6564840 Mon Sep 17 00:00:00 >> > 2001 >> >> > From: Joakim Tjernlund >> >> > Date: Tue, 24 Mar 2009 10:19:27 +0100 >> >> &

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-30 Thread Joakim Tjernlund
b1f37f4818c0fd0217b93eb38ab6564840 Mon Sep 17 00:00:00 > > 2001 > >> > From: Joakim Tjernlund > >> > Date: Tue, 24 Mar 2009 10:19:27 +0100 > >> > Subject: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context. > >> > Also increase

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-30 Thread Li Yang
t; From: Joakim Tjernlund >> > Date: Tue, 24 Mar 2009 10:19:27 +0100 >> > Subject: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context. >> >  Also increase NAPI weight somewhat. >> >  This will make the system alot more responsive while >> >

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-25 Thread Joakim Tjernlund
David Miller wrote on 25/03/2009 22:40:41: > > From: Eric Dumazet > Date: Wed, 25 Mar 2009 15:04:26 +0100 > > > Joakim Tjernlund a écrit : > > > + /* Tx event processing */ > > > + spin_lock(&ugeth->lock); > > > + for (i = 0; i < ug_info->numQueuesTx; i++) { > > > + ucc_geth_tx(ugeth

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-25 Thread David Miller
From: Joakim Tjernlund Date: Wed, 25 Mar 2009 16:16:24 +0100 > UCC_GETH_DEV_WEIGHT needs to be a bit bigger than the number of RX > HW buffers avaliable, otherwise one won't be able to drain the whole > queue in one go. Changing weight to something bigger made a big > difference. You're not supp

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-25 Thread David Miller
From: Eric Dumazet Date: Wed, 25 Mar 2009 15:04:26 +0100 > Joakim Tjernlund a écrit : > > + /* Tx event processing */ > > + spin_lock(&ugeth->lock); > > + for (i = 0; i < ug_info->numQueuesTx; i++) { > > + ucc_geth_tx(ugeth->dev, i); > > + } > > + spin_unlock(&ugeth->lock); >

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-25 Thread David Miller
From: Joakim Tjernlund Date: Wed, 25 Mar 2009 14:30:49 +0100 > >From 1c2f23b1f37f4818c0fd0217b93eb38ab6564840 Mon Sep 17 00:00:00 2001 > From: Joakim Tjernlund > Date: Tue, 24 Mar 2009 10:19:27 +0100 > Subject: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context. >

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-25 Thread Joakim Tjernlund
; Subject: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context. > > Also increase NAPI weight somewhat. > > This will make the system alot more responsive while > > ping flooding the ucc_geth ethernet interaface. > > Some time ago I've tried a similar

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-25 Thread Joakim Tjernlund
> > Subject: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context. > > Also increase NAPI weight somewhat. > > This will make the system alot more responsive while > > ping flooding the ucc_geth ethernet interaface. > > Some time ago I've tried a simi

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-25 Thread Joakim Tjernlund
Eric Dumazet wrote on 25/03/2009 15:04:26: > Joakim Tjernlund a écrit : > >>From 1c2f23b1f37f4818c0fd0217b93eb38ab6564840 Mon Sep 17 00:00:00 2001 > > From: Joakim Tjernlund > > Date: Tue, 24 Mar 2009 10:19:27 +0100 > > Subject: [PATCH] ucc_geth: Move freeing

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-25 Thread Anton Vorontsov
On Wed, Mar 25, 2009 at 02:30:49PM +0100, Joakim Tjernlund wrote: > >>From 1c2f23b1f37f4818c0fd0217b93eb38ab6564840 Mon Sep 17 00:00:00 2001 > From: Joakim Tjernlund > Date: Tue, 24 Mar 2009 10:19:27 +0100 > Subject: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-25 Thread Eric Dumazet
Joakim Tjernlund a écrit : >>From 1c2f23b1f37f4818c0fd0217b93eb38ab6564840 Mon Sep 17 00:00:00 2001 > From: Joakim Tjernlund > Date: Tue, 24 Mar 2009 10:19:27 +0100 > Subject: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context. > Also increase NAPI weight somewhat.

[PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-25 Thread Joakim Tjernlund
>From 1c2f23b1f37f4818c0fd0217b93eb38ab6564840 Mon Sep 17 00:00:00 2001 From: Joakim Tjernlund Date: Tue, 24 Mar 2009 10:19:27 +0100 Subject: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context. Also increase NAPI weight somewhat. This will make the system alot more responsive wh