Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-09-24 Thread David Brownell
On Thursday 28 August 2008, Arnd Bergmann wrote: +/*- + Gadget driver register and unregister. + --*/ +int

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-09-24 Thread David Brownell
On Thursday 28 August 2008, Arnd Bergmann wrote: If the gadget hardware drivers were registering the device with a gadget_bus_type, you could still enforce the only one protocol rule by binding every protocol to every device in that bus type. And you'd have to rewrite all the gadget drivers

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-09-02 Thread Li Yang
On Mon, Sep 1, 2008 at 9:52 PM, Anton Vorontsov [EMAIL PROTECTED] wrote: On Thu, Aug 28, 2008 at 05:43:33PM +0800, Li Yang wrote: Some of Freescale SoC chips have a QE or CPM co-processor which supports full speed USB. The driver adds device mode support of both QE and CPM USB controller to

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-09-02 Thread Li Yang
On Tue, Sep 2, 2008 at 1:11 AM, Anton Vorontsov [EMAIL PROTECTED] wrote: On Thu, Aug 28, 2008 at 05:43:33PM +0800, Li Yang wrote: Some of Freescale SoC chips have a QE or CPM co-processor which supports full speed USB. The driver adds device mode support of both QE and CPM USB controller to

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-09-02 Thread Joakim Tjernlund
On Tue, 2008-09-02 at 15:35 +0800, Li Yang wrote: On Tue, Sep 2, 2008 at 1:11 AM, Anton Vorontsov [EMAIL PROTECTED] wrote: On Thu, Aug 28, 2008 at 05:43:33PM +0800, Li Yang wrote: Some of Freescale SoC chips have a QE or CPM co-processor which supports full speed USB. The driver adds

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-09-01 Thread Anton Vorontsov
On Thu, Aug 28, 2008 at 05:43:33PM +0800, Li Yang wrote: Some of Freescale SoC chips have a QE or CPM co-processor which supports full speed USB. The driver adds device mode support of both QE and CPM USB controller to Linux USB gadget. The driver is tested with MPC8360 and MPC8272, and

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-09-01 Thread Anton Vorontsov
On Thu, Aug 28, 2008 at 05:43:33PM +0800, Li Yang wrote: Some of Freescale SoC chips have a QE or CPM co-processor which supports full speed USB. The driver adds device mode support of both QE and CPM USB controller to Linux USB gadget. The driver is tested with MPC8360 and MPC8272, and

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-09-01 Thread Anton Vorontsov
On Thu, Aug 28, 2008 at 05:43:33PM +0800, Li Yang wrote: Some of Freescale SoC chips have a QE or CPM co-processor which supports full speed USB. The driver adds device mode support of both QE and CPM USB controller to Linux USB gadget. The driver is tested with MPC8360 and MPC8272, and

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-08-29 Thread Li Yang
On Thu, 2008-08-28 at 17:04 +0200, Arnd Bergmann wrote: On Thursday 28 August 2008, Li Yang wrote: Some of Freescale SoC chips have a QE or CPM co-processor which supports full speed USB. The driver adds device mode support of both QE and CPM USB controller to Linux USB gadget. The

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-08-29 Thread Arnd Bergmann
On Friday 29 August 2008, Li Yang wrote: Not a problem, but an observation: Most new code uses work queues instead of tasklets these days, which gives you more predictable real time latencies. If you don't have a specific reason to prefer a tasklet, just use a workqueue here. Is

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-08-29 Thread Alan Stern
On Fri, 29 Aug 2008, Arnd Bergmann wrote: Does building a kernel image that can run on different hardware without rebuilding also violate the relevant standards? No.  That isn't what Arnd was concerned about.  He noted that even if you did build multiple modules, only one of them

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-08-29 Thread Arnd Bergmann
On Friday 29 August 2008, Alan Stern wrote: The standard requires that there can only be one protocol handler per physical interface, which is a reasonable limitation. No, you've got it exactly backward.  There can be multiple protocol handlers per physical interface, but there must be

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-08-29 Thread Arnd Bergmann
On Friday 29 August 2008, Alan Stern wrote: I thought you _were_ arguing against that.  Unless I misunderstood, your original complaint was that since each peripheral controller driver defines usb_gadget_{un}register_driver, there can be only one controller driver loaded at a time. That's

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-08-29 Thread Alan Stern
On Fri, 29 Aug 2008, Arnd Bergmann wrote: On Friday 29 August 2008, Alan Stern wrote: I thought you _were_ arguing against that.  Unless I misunderstood, your original complaint was that since each peripheral controller driver defines usb_gadget_{un}register_driver, there can be only one

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-08-28 Thread Scott Wood
On Thu, Aug 28, 2008 at 05:43:33PM +0800, Li Yang wrote: +config USB_GADGET_FSL_QE + boolean Freescale QE/CPM USB Device Controller + depends on FSL_SOC (QUICC_ENGINE || CPM) + help +Some of Freescale PowerPC processors have a Full Speed +QE/CPM2 USB controller,

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-08-28 Thread Alan Stern
On Thu, 28 Aug 2008, Arnd Bergmann wrote: Not addressing this driver in particular, but the USB gadget layer in general: This is a horrible interface, since every gadget driver exports the same symbols, you can never build a kernel that includes more than one gadget driver. Even if the

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-08-28 Thread Alan Stern
On Thu, 28 Aug 2008, Scott Wood wrote: Alan Stern wrote: This was done deliberately. The relevant standards state that a USB device can have no more than one peripheral interface. Does building a kernel image that can run on different hardware without rebuilding also violate the

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-08-28 Thread Arnd Bergmann
On Thursday 28 August 2008, Alan Stern wrote: On Thu, 28 Aug 2008, Scott Wood wrote: Alan Stern wrote: This was done deliberately.  The relevant standards state that a USB device can have no more than one peripheral interface. Does building a kernel image that can run on different

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-08-28 Thread Scott Wood
Alan Stern wrote: This was done deliberately. The relevant standards state that a USB device can have no more than one peripheral interface. Does building a kernel image that can run on different hardware without rebuilding also violate the relevant standards? And who's to say that there

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-08-15 Thread Anton Vorontsov
On Wed, Aug 06, 2008 at 03:16:40PM +0800, Li Yang wrote: Some of Freescale SoC chips have a QE or CPM co-processor which supports full speed USB. The driver adds device mode support of both QE and CPM USB controller to Linux USB gadget. The driver is tested with MPC8360 and MPC8272, and

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-08-06 Thread Timur Tabi
On Wed, Aug 6, 2008 at 2:16 AM, Li Yang [EMAIL PROTECTED] wrote: +/*- + * Mask definitions for usb BD * + **/ +#define