Re: [PATCH -next] serial: pmac_zilog: use for_each_child_of_node() macro

[Michael Ellerman]

On Wed, 16 Sep 2020 14:21:38 +0800, Qinglang Miao wrote:
> Use for_each_child_of_node() macro instead of open coding it.

Applied to powerpc/next.

[1/1] serial: pmac_zilog: use for_each_child_of_node() macro
  https://git.kernel.org/powerpc/c/1d42e07e9c249b7a032fba82b673ee8a8d6bd7b7

cheers

[PATCH -next] serial: pmac_zilog: use for_each_child_of_node() macro

[Qinglang Miao]

Use for_each_child_of_node() macro instead of open coding it.

Signed-off-by: Qinglang Miao 
---
 drivers/tty/serial/pmac_zilog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/pmac_zilog.c b/drivers/tty/serial/pmac_zilog.c
index 96e7aa479..063484b22 100644
--- a/drivers/tty/serial/pmac_zilog.c
+++ b/drivers/tty/serial/pmac_zilog.c
@@ -1644,7 +1644,7 @@ static int __init pmz_probe(void)
 * TODO: Add routines with proper locking to do that...
 */
node_a = node_b = NULL;
-   for (np = NULL; (np = of_get_next_child(node_p, np)) != NULL;) {
+   for_each_child_of_node(node_p, np) {
if (of_node_name_prefix(np, "ch-a"))
node_a = of_node_get(np);
else if (of_node_name_prefix(np, "ch-b"))
-- 
2.23.0