Re: (subset) [PATCH 000/173] ALSA/ASoC: Convert to platform remove callback returning void
On Wed, 15 Mar 2023 16:04:52 +0100, Uwe Kleine-König wrote: > this series adapts the platform drivers below sound/ to use the .remove_new() > callback. Compared to the traditional .remove() callback .remove_new() returns > no value. This is a good thing because the driver core doesn't (and cannot) > cope for errors during remove. The only effect of a non-zero return value in > .remove() is that the driver core emits a warning. The device is removed > anyhow > and an early return from .remove() usually yields a resource leak. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [001/173] ALSA: sh: aica: Drop if blocks with always false condition commit: e3a8459d726532be70fa917e39812570618b857e [002/173] ASoC: amd: acp: rembrandt: Drop if blocks with always false condition commit: 9ac0d69ee5891c2d0f0425acbb13993ceef9cd12 [003/173] ALSA: pxa2xx: Convert to platform remove callback returning void commit: 3210e62ab2f63b3ecdacc2c06ca8c8a91d1bf656 [004/173] ALSA: atmel: ac97: Convert to platform remove callback returning void commit: 45cc35e81322117dfc27fbfded2e0263018175a0 [005/173] ALSA: mts64: Convert to platform remove callback returning void commit: 5909d9e5b6c927ea91ace61365049a2f365a7d7e [006/173] ALSA: portman2x4: Convert to platform remove callback returning void commit: 962bdc9645036b1300c4930e147b5e9a0c587c81 [007/173] ALSA: mips/hal2: Convert to platform remove callback returning void commit: b54a2377ec02d52b7bb5dab381e9a45ba0bc617a [008/173] ALSA: mips/sgio2audio: Convert to platform remove callback returning void commit: 0505c87c00e8e0adb64c9cfb97ea4882899bea3e [009/173] ALSA: hda/tegra: Convert to platform remove callback returning void commit: d8a3441b53682883c16d6997d059e1cc2ac739c8 [010/173] ALSA: ppc/powermac: Convert to platform remove callback returning void commit: c3d8cb1929fc64e8c3d14f27e9540e72aee8ed08 [011/173] ALSA: sh: aica: Convert to platform remove callback returning void commit: de0f49b86d12384e8f3ddf7dc651a93c2c0c551b [012/173] ALSA: sh_dac_audio: Convert to platform remove callback returning void commit: a0f4aa0a9f841693a6487315751c12a2f5773574 [013/173] ASoC: adi: axi-i2s: Convert to platform remove callback returning void commit: 711c5b4e36a3345cd0de597a9c5b7f5911abfd51 [014/173] ASoC: adi: axi-spdif: Convert to platform remove callback returning void commit: a0d18db09ca5b43e832c913b2375f3f6d124cc3b [015/173] ASoC: amd: acp-pcm-dma: Convert to platform remove callback returning void commit: 6c24eb02518e3c5140b80144ec000bfa5bf7 [016/173] ASoC: amd: acp: rembrandt: Convert to platform remove callback returning void commit: 37846af6d08ccdca8308e3d4bfec9f6d97e8eec2 [017/173] ASoC: amd: acp: renoir: Convert to platform remove callback returning void commit: da8a3ceb45be5d711f109df5bb12261adb790391 [018/173] ASoC: amd: ps: Convert to platform remove callback returning void commit: 5b6bacfa1a7bc353d14189a628d8617a26e8381b [019/173] ASoC: amd: raven: acp3x-pcm-dma: Convert to platform remove callback returning void commit: 599914e146a772f7ceb39912a73565d90336e5e3 [020/173] ASoC: amd: raven: acp3x-pdm-dma: Convert to platform remove callback returning void commit: 725d4edfa528f07acfda3e080bf1827e5eea0399 [021/173] ASoC: amd: vangogh: acp5x-pcm-dma: Convert to platform remove callback returning void commit: 8564d4f22ce7cbf989af4ba004b44b1878d1b984 [022/173] ASoC: amd: yc: acp6x-pdm-dma: Convert to platform remove callback returning void commit: 0e940c75e307f61fdf049ee7ac21d672f91883f3 [023/173] ASoC: apple: mca: Convert to platform remove callback returning void commit: eb5a9cf29f1e5b6290e168d405eef98b42f158a4 [024/173] ASoC: atmel: atmel-i2s: Convert to platform remove callback returning void commit: d0486266a6ba028fe0197c721994f3de5d21550a [025/173] ASoC: atmel: atmel_wm8904: Convert to platform remove callback returning void commit: 0278eb3275df6121ecbab848269495f9ca7f5c7a [026/173] ASoC: atmel: mchp-i2s-mcc: Convert to platform remove callback returning void commit: b0570709d123ee8bfed32f968d665366fb1a6d2d [027/173] ASoC: atmel: mchp-pdmc: Convert to platform remove callback returning void commit: 86fdd4825459db4ec831d2d41a5e27d45dff2641 [028/173] ASoC: atmel: mchp-spdifrx: Convert to platform remove callback returning void commit: 879f2ce0a95701695f2b7648ca81aff543631b1d [029/173] ASoC: atmel: mchp-spdiftx: Convert to platform remove callback returning void commit: c1d51c27d22af56e53e2d739cf533182c2a3fca3 [030/173] ASoC: atmel: mikroe-proto: Convert to platform remove callback returning void commit: 2328c4871bd33ce3be5c56a413a79c6b23535217 [031/173] ASoC: atmel: sam9g20_wm8731: Convert to platform remove
Re: [PATCH 000/173] ALSA/ASoC: Convert to platform remove callback returning void
On Wed, 15 Mar 2023 16:04:52 +0100, Uwe Kleine-König wrote: > > Hello, > > this series adapts the platform drivers below sound/ to use the .remove_new() > callback. Compared to the traditional .remove() callback .remove_new() returns > no value. This is a good thing because the driver core doesn't (and cannot) > cope for errors during remove. The only effect of a non-zero return value in > .remove() is that the driver core emits a warning. The device is removed > anyhow > and an early return from .remove() usually yields a resource leak. > > By changing the remove callback to return void driver authors cannot > reasonably assume any more that there is some kind of cleanup later. > > The first two patches simplify a driver each to return zero unconditionally, > and then all drivers are trivially converted to .remove_new(). > > There are nearly no interdependencies in this patch set---only 1 <- 11 and > 2 <- 16. So even if some individual problems are found (I don't expect that), > the other patches can (and from my POV should) still be applied. > > Best regards > Uwe > > Uwe Kleine-König (173): (snip) For the whole series, Acked-by: Takashi Iwai thanks, Takashi
[PATCH 000/173] ALSA/ASoC: Convert to platform remove callback returning void
Hello, this series adapts the platform drivers below sound/ to use the .remove_new() callback. Compared to the traditional .remove() callback .remove_new() returns no value. This is a good thing because the driver core doesn't (and cannot) cope for errors during remove. The only effect of a non-zero return value in .remove() is that the driver core emits a warning. The device is removed anyhow and an early return from .remove() usually yields a resource leak. By changing the remove callback to return void driver authors cannot reasonably assume any more that there is some kind of cleanup later. The first two patches simplify a driver each to return zero unconditionally, and then all drivers are trivially converted to .remove_new(). There are nearly no interdependencies in this patch set---only 1 <- 11 and 2 <- 16. So even if some individual problems are found (I don't expect that), the other patches can (and from my POV should) still be applied. Best regards Uwe Uwe Kleine-König (173): ALSA: sh: aica: Drop if blocks with always false condition ASoC: amd: acp: rembrandt: Drop if blocks with always false condition ALSA: pxa2xx: Convert to platform remove callback returning void ALSA: atmel: ac97: Convert to platform remove callback returning void ALSA: mts64: Convert to platform remove callback returning void ALSA: portman2x4: Convert to platform remove callback returning void ALSA: mips/hal2: Convert to platform remove callback returning void ALSA: mips/sgio2audio: Convert to platform remove callback returning void ALSA: hda/tegra: Convert to platform remove callback returning void ALSA: ppc/powermac: Convert to platform remove callback returning void ALSA: sh: aica: Convert to platform remove callback returning void ALSA: sh_dac_audio: Convert to platform remove callback returning void ASoC: adi: axi-i2s: Convert to platform remove callback returning void ASoC: adi: axi-spdif: Convert to platform remove callback returning void ASoC: amd: acp-pcm-dma: Convert to platform remove callback returning void ASoC: amd: acp: rembrandt: Convert to platform remove callback returning void ASoC: amd: acp: renoir: Convert to platform remove callback returning void ASoC: amd: ps: Convert to platform remove callback returning void ASoC: amd: raven: acp3x-pcm-dma: Convert to platform remove callback returning void ASoC: amd: raven: acp3x-pdm-dma: Convert to platform remove callback returning void ASoC: amd: vangogh: acp5x-pcm-dma: Convert to platform remove callback returning void ASoC: amd: yc: acp6x-pdm-dma: Convert to platform remove callback returning void ASoC: apple: mca: Convert to platform remove callback returning void ASoC: atmel: atmel-i2s: Convert to platform remove callback returning void ASoC: atmel: atmel_wm8904: Convert to platform remove callback returning void ASoC: atmel: mchp-i2s-mcc: Convert to platform remove callback returning void ASoC: atmel: mchp-pdmc: Convert to platform remove callback returning void ASoC: atmel: mchp-spdifrx: Convert to platform remove callback returning void ASoC: atmel: mchp-spdiftx: Convert to platform remove callback returning void ASoC: atmel: mikroe-proto: Convert to platform remove callback returning void ASoC: atmel: sam9g20_wm8731: Convert to platform remove callback returning void ASoC: atmel: sam9x5_wm8731: Convert to platform remove callback returning void ASoC: atmel: tse850-pcm5142: Convert to platform remove callback returning void ASoC: au1x: ac97c: Convert to platform remove callback returning void ASoC: au1x: i2sc: Convert to platform remove callback returning void ASoC: au1x: psc-ac97: Convert to platform remove callback returning void ASoC: au1x: psc-i2s: Convert to platform remove callback returning void ASoC: bcm: bcm63xx-i2s-whistler: Convert to platform remove callback returning void ASoC: bcm: cygnus-ssp: Convert to platform remove callback returning void ASoC: cirrus: edb93xx: Convert to platform remove callback returning void ASoC: cirrus: ep93xx-i2s: Convert to platform remove callback returning void ASoC: codecs: cs47l15: Convert to platform remove callback returning void ASoC: codecs: cs47l24: Convert to platform remove callback returning void ASoC: codecs: cs47l35: Convert to platform remove callback returning void ASoC: codecs: cs47l85: Convert to platform remove callback returning void ASoC: codecs: cs47l90: Convert to platform remove callback returning void ASoC: codecs: cs47l92: Convert to platform remove callback returning void ASoC: codecs: inno_rk3036: Convert to platform remove callback returning void ASoC: codecs: lpass-rx-macro: Convert to platform remove callback returning void ASoC: codecs: lpass-tx-macro: Convert to platform remove callback returning void ASoC: codecs: lpass-va-macro: Convert
