Re: [PATCH 01/10] fs: don't allow kernel reads and writes without iter ops

2020-08-29 Thread 'Christoph Hellwig'
On Thu, Aug 27, 2020 at 03:58:02PM +, David Laight wrote: > Is there a real justification for that? > For system calls supplying both methods makes sense to avoid > the extra code paths for a simple read/write. Al asked for it as two of our four in-tree instances do have weird semantics, and w

RE: [PATCH 01/10] fs: don't allow kernel reads and writes without iter ops

2020-08-27 Thread David Laight
From: Christoph Hellwig > Sent: 27 August 2020 16:00 > > Don't allow calling ->read or ->write with set_fs as a preparation for > killing off set_fs. All the instances that we use kernel_read/write on > are using the iter ops already. > > If a file has both the regular ->read/->write methods and

[PATCH 01/10] fs: don't allow kernel reads and writes without iter ops

2020-08-27 Thread Christoph Hellwig
Don't allow calling ->read or ->write with set_fs as a preparation for killing off set_fs. All the instances that we use kernel_read/write on are using the iter ops already. If a file has both the regular ->read/->write methods and the iter variants those could have different semantics for messed