Hi Logan,
[...]
> Thanks, this is a great cleanup. I've reviewed the entire series.
>
> Reviewed-by: Logan Gunthorpe
Thank you! Appreciate it!
> I agree that the new lines that are missing should be added.
While working on the simple change to add the missing new lines, I've
found that we
On 2021-05-09 10:14 p.m., Krzysztof Wilczyński wrote:
> The sysfs_emit() and sysfs_emit_at() functions were introduced to make
> it less ambiguous which function is preferred when writing to the output
> buffer in a device attribute's "show" callback [1].
>
> Convert the PCI sysfs object
[+cc Joe for visibility]
[...]
> spin_lock(_alignment_lock);
> if (resource_alignment_param)
> - count = scnprintf(buf, PAGE_SIZE, "%s",
> resource_alignment_param);
> + count = sysfs_emit(buf, "%s", resource_alignment_param);
>
The sysfs_emit() and sysfs_emit_at() functions were introduced to make
it less ambiguous which function is preferred when writing to the output
buffer in a device attribute's "show" callback [1].
Convert the PCI sysfs object "show" functions from sprintf(), snprintf()
and scnprintf() to