Re: [PATCH 01/16] pmac_zilog: fix unexpected irq

2011-11-27 Thread Benjamin Herrenschmidt
> Removing ifdefs makes the changes more invasive and the suspend/resume > code then has to be addressed, which I've avoided. > > The suspend/resume code path can't be tested on m68k macs and the common > code paths I can't easily test on a powermac. > > This patch should not be needed because

Re: [PATCH 01/16] pmac_zilog: fix unexpected irq

2011-11-24 Thread Finn Thain
On Thu, 24 Nov 2011, Alan Cox wrote: > Given the change should work for all hardware do we really need the > ifdefs. Far better I would have thought to just change it so we don't > have to maintain what is effectively two versions of the code between > now and 2038. I agree. > > So no ack f

RE: [PATCH 01/16] pmac_zilog: fix unexpected irq

2011-11-24 Thread Benjamin Herrenschmidt
On Thu, 2011-11-24 at 15:28 +, David Laight wrote: > > On most 68k Macs the SCC IRQ is an autovector interrupt and cannot be > > masked. This can be a problem when pmac_zilog starts up. > > Wouldn't this also happen if the interrupt were shared? > Hopefully nothing vaguely modern uses the bor

Re: [PATCH 01/16] pmac_zilog: fix unexpected irq

2011-11-24 Thread Benjamin Herrenschmidt
On Thu, 2011-11-24 at 14:56 +, Alan Cox wrote: > > This patch has been tested on a variety of m68k Macs but no > PowerMacs. > > > > I am re-sending this patch Cc linux-serial. It still needs a > suitable ack > > so that Geert can push it through his tree. > > Given the change should work for

RE: [PATCH 01/16] pmac_zilog: fix unexpected irq

2011-11-24 Thread David Laight
> On most 68k Macs the SCC IRQ is an autovector interrupt and cannot be > masked. This can be a problem when pmac_zilog starts up. Wouldn't this also happen if the interrupt were shared? Hopefully nothing vaguely modern uses the borked Zilog 8530 SCC (which I presume is the part in question - b

Re: [PATCH 01/16] pmac_zilog: fix unexpected irq

2011-11-24 Thread Alan Cox
On Fri, 25 Nov 2011 01:34:58 +1100 (EST) Finn Thain wrote: > > On most 68k Macs the SCC IRQ is an autovector interrupt and cannot be > masked. This can be a problem when pmac_zilog starts up. > > For example, the serial debugging code in arch/m68k/kernel/head.S may be > used beforehand. It di

[PATCH 01/16] pmac_zilog: fix unexpected irq

2011-11-24 Thread Finn Thain
On most 68k Macs the SCC IRQ is an autovector interrupt and cannot be masked. This can be a problem when pmac_zilog starts up. For example, the serial debugging code in arch/m68k/kernel/head.S may be used beforehand. It disables the SCC interrupts at the chip but doesn't ack them. Then when a

[PATCH 01/16] pmac_zilog: fix unexpected irq

2011-10-23 Thread Finn Thain
On most 68k Macs the SCC IRQ is an autovector interrupt and cannot be masked. This can be a problem when pmac_zilog starts up. For example, the serial debugging code in arch/m68k/kernel/head.S may be used beforehand. It disables the SCC interrupts at the chip but doesn't ack them. Then when a p