Re: [PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness()

[Sam Ravnborg]

Hi Christophe,
On Mon, Jan 09, 2023 at 05:44:46PM +, Christophe Leroy wrote:
> 
> 
> Le 07/01/2023 à 19:26, Sam Ravnborg via B4 Submission Endpoint a écrit :
> > From: Sam Ravnborg 
> > 
> > Introduce backlight_get_brightness() to simplify logic
> > and avoid direct access to backlight properties.
> 
> When I read 'introduce' I understand that you are adding a new function.
> 
> In fact backlight_get_brightness() already exists, so maybe replace 
> 'introduce' by 'use'

Thanks for your feedback. A similar patch is already applied to the
fbdev tree, so this patch can be ignored.

Sam

Re: [PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness()

[Christophe Leroy]

Le 07/01/2023 à 19:26, Sam Ravnborg via B4 Submission Endpoint a écrit :
> From: Sam Ravnborg 
> 
> Introduce backlight_get_brightness() to simplify logic
> and avoid direct access to backlight properties.

When I read 'introduce' I understand that you are adding a new function.

In fact backlight_get_brightness() already exists, so maybe replace 
'introduce' by 'use'


> 
> Signed-off-by: Sam Ravnborg 
> Cc: Bartlomiej Zolnierkiewicz 
> Cc: Sam Ravnborg 
> Cc: Daniel Vetter 
> Cc: Souptick Joarder 
> Cc: Maarten Lankhorst 
> Cc: Jason Yan 
> Cc: Jani Nikula 
> Cc: Arnd Bergmann 
> ---
>   drivers/video/fbdev/aty/atyfb_base.c | 8 +---
>   1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/video/fbdev/aty/atyfb_base.c 
> b/drivers/video/fbdev/aty/atyfb_base.c
> index 0ccf5d401ecb..ca361e215904 100644
> --- a/drivers/video/fbdev/aty/atyfb_base.c
> +++ b/drivers/video/fbdev/aty/atyfb_base.c
> @@ -2219,13 +2219,7 @@ static int aty_bl_update_status(struct 
> backlight_device *bd)
>   {
>  struct atyfb_par *par = bl_get_data(bd);
>  unsigned int reg = aty_ld_lcd(LCD_MISC_CNTL, par);
> -   int level;
> -
> -   if (bd->props.power != FB_BLANK_UNBLANK ||
> -   bd->props.fb_blank != FB_BLANK_UNBLANK)
> -   level = 0;
> -   else
> -   level = bd->props.brightness;
> +   int level = backlight_get_brightness(bd);
> 
>  reg |= (BLMOD_EN | BIASMOD_EN);
>  if (level > 0) {
> 
> --
> 2.34.1

[PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness()

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg 

Introduce backlight_get_brightness() to simplify logic
and avoid direct access to backlight properties.

Signed-off-by: Sam Ravnborg 
Cc: Bartlomiej Zolnierkiewicz 
Cc: Sam Ravnborg 
Cc: Daniel Vetter 
Cc: Souptick Joarder 
Cc: Maarten Lankhorst 
Cc: Jason Yan 
Cc: Jani Nikula 
Cc: Arnd Bergmann 
---
 drivers/video/fbdev/aty/atyfb_base.c | 8 +---
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/video/fbdev/aty/atyfb_base.c 
b/drivers/video/fbdev/aty/atyfb_base.c
index 0ccf5d401ecb..ca361e215904 100644
--- a/drivers/video/fbdev/aty/atyfb_base.c
+++ b/drivers/video/fbdev/aty/atyfb_base.c
@@ -2219,13 +2219,7 @@ static int aty_bl_update_status(struct backlight_device 
*bd)
 {
struct atyfb_par *par = bl_get_data(bd);
unsigned int reg = aty_ld_lcd(LCD_MISC_CNTL, par);
-   int level;
-
-   if (bd->props.power != FB_BLANK_UNBLANK ||
-   bd->props.fb_blank != FB_BLANK_UNBLANK)
-   level = 0;
-   else
-   level = bd->props.brightness;
+   int level = backlight_get_brightness(bd);
 
reg |= (BLMOD_EN | BIASMOD_EN);
if (level > 0) {

-- 
2.34.1