Re: [PATCH 06/18] powerpc/numa: remove unreachable topology timer code

[Srikar Dronamraju]

* Nathan Lynch  [2020-06-12 00:12:26]:

> Since vphn_enabled is always 0, we can stub out
> timed_topology_update() and remove the code which becomes unreachable.
> 
> Signed-off-by: Nathan Lynch 
> ---
>  arch/powerpc/mm/numa.c | 21 -
>  1 file changed, 21 deletions(-)
> 

Looks good to me.

Reviewed-by: Srikar Dronamraju 
-- 
Thanks and Regards
Srikar Dronamraju

[PATCH 06/18] powerpc/numa: remove unreachable topology timer code

[Nathan Lynch]

Since vphn_enabled is always 0, we can stub out
timed_topology_update() and remove the code which becomes unreachable.

Signed-off-by: Nathan Lynch 
---
 arch/powerpc/mm/numa.c | 21 -
 1 file changed, 21 deletions(-)

diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index 1b89bacb8975..6207297490a8 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -1129,13 +1129,9 @@ struct topology_update_data {
int new_nid;
 };
 
-#define TOPOLOGY_DEF_TIMER_SECS60
-
 static cpumask_t cpu_associativity_changes_mask;
 static const int vphn_enabled;
 static const int prrn_enabled;
-static void reset_topology_timer(void);
-static int topology_timer_secs = 1;
 static int topology_inited;
 
 /*
@@ -1143,15 +1139,6 @@ static int topology_inited;
  */
 int timed_topology_update(int nsecs)
 {
-   if (vphn_enabled) {
-   if (nsecs > 0)
-   topology_timer_secs = nsecs;
-   else
-   topology_timer_secs = TOPOLOGY_DEF_TIMER_SECS;
-
-   reset_topology_timer();
-   }
-
return 0;
 }
 
@@ -1438,14 +1425,6 @@ static void topology_schedule_update(void)
schedule_work(_work);
 }
 
-static struct timer_list topology_timer;
-
-static void reset_topology_timer(void)
-{
-   if (vphn_enabled)
-   mod_timer(_timer, jiffies + topology_timer_secs * HZ);
-}
-
 /*
  * Start polling for associativity changes.
  */
-- 
2.25.4