Re: [PATCH 065/493] i2c: remove use of __devexit_p

2012-11-26 Thread Bill Pemberton 
Wolfram Sang writes:
 
 
 --osDK9TLjxFScVI/L
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Tue, Nov 20, 2012 at 02:46:21PM +0100, Jean Delvare wrote:
  On Mon, 19 Nov 2012 13:20:14 -0500, Bill Pemberton wrote:
   CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
   needed.
 =20
  As mentioned on the lm-sensors list for hwmon patches already, I think
  it would be much clearer to not split __devexit, __devexit_p, __devinit
  etc. removal into separate patches. One patch per subsystem would be
  easier to review and apply. If patches grow too large then you'd rather
  split in a different direction, for example drivers/i2c/muxes vs.
  drivers/i2c/busses or even grouped by related bus drivers (see entries
  I2C OVER PARALLEL PORT and I2C/SMBUS CONTROLLER DRIVERS FOR PC in
  MAINTAINERS for examples of meaningful groups.)
 
 I agree with Jean here. Is there a V2 planned? With a change like this?
 

Yes, my plan is to redo the patches for the i2c subsystem.

-- 
Bill
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 065/493] i2c: remove use of __devexit_p

2012-11-22 Thread Wolfram Sang 
On Tue, Nov 20, 2012 at 02:46:21PM +0100, Jean Delvare wrote:
 On Mon, 19 Nov 2012 13:20:14 -0500, Bill Pemberton wrote:
  CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
  needed.
 
 As mentioned on the lm-sensors list for hwmon patches already, I think
 it would be much clearer to not split __devexit, __devexit_p, __devinit
 etc. removal into separate patches. One patch per subsystem would be
 easier to review and apply. If patches grow too large then you'd rather
 split in a different direction, for example drivers/i2c/muxes vs.
 drivers/i2c/busses or even grouped by related bus drivers (see entries
 I2C OVER PARALLEL PORT and I2C/SMBUS CONTROLLER DRIVERS FOR PC in
 MAINTAINERS for examples of meaningful groups.)

I agree with Jean here. Is there a V2 planned? With a change like this?

-- 
Pengutronix e.K.   | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/  |


signature.asc
Description: Digital signature
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 065/493] i2c: remove use of __devexit_p

2012-11-20 Thread Shubhrajyoti Datta 
On Mon, Nov 19, 2012 at 11:50 PM, Bill Pemberton wf...@virginia.edu wrote:
 CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
 needed.

 Reviewed-by: Shubhrajyoti D shubhrajy...@ti.com
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 065/493] i2c: remove use of __devexit_p

2012-11-20 Thread Jean Delvare 
On Mon, 19 Nov 2012 13:20:14 -0500, Bill Pemberton wrote:
 CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
 needed.

As mentioned on the lm-sensors list for hwmon patches already, I think
it would be much clearer to not split __devexit, __devexit_p, __devinit
etc. removal into separate patches. One patch per subsystem would be
easier to review and apply. If patches grow too large then you'd rather
split in a different direction, for example drivers/i2c/muxes vs.
drivers/i2c/busses or even grouped by related bus drivers (see entries
I2C OVER PARALLEL PORT and I2C/SMBUS CONTROLLER DRIVERS FOR PC in
MAINTAINERS for examples of meaningful groups.)

-- 
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH 065/493] i2c: remove use of __devexit_p

2012-11-19 Thread Bill Pemberton 
CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.

Signed-off-by: Bill Pemberton wf...@virginia.edu
Cc: Jean Delvare kh...@linux-fr.org 
Cc: Wolfram Sang w.s...@pengutronix.de 
Cc: Ben Dooks  ben-li...@fluff.org 
Cc: Rudolf Marek r.ma...@assembler.cz 
Cc: Jochen Friedrich joc...@scram.de 
Cc: Peter Korsgaard jac...@sunsite.dk 
Cc: Tony Lindgren t...@atomide.com 
Cc: Olof Johansson o...@lixom.net 
Cc: Vitaly Wool vitalyw...@gmail.com 
Cc: Guan Xuetao g...@mprc.pku.edu.cn 
Cc: Barry Song baohua.s...@csr.com 
Cc: Mark M. Hoffman mhoff...@lightlink.com 
Cc: linux-...@vger.kernel.org 
Cc: linuxppc-dev@lists.ozlabs.org 
Cc: linux-o...@vger.kernel.org 
Cc: linux-arm-ker...@lists.infradead.org 
---
 drivers/i2c/busses/i2c-ali1535.c| 2 +-
 drivers/i2c/busses/i2c-ali1563.c| 2 +-
 drivers/i2c/busses/i2c-ali15x3.c| 2 +-
 drivers/i2c/busses/i2c-amd756.c | 2 +-
 drivers/i2c/busses/i2c-amd8111.c| 2 +-
 drivers/i2c/busses/i2c-at91.c   | 2 +-
 drivers/i2c/busses/i2c-au1550.c | 2 +-
 drivers/i2c/busses/i2c-cpm.c| 2 +-
 drivers/i2c/busses/i2c-designware-pcidrv.c  | 2 +-
 drivers/i2c/busses/i2c-designware-platdrv.c | 2 +-
 drivers/i2c/busses/i2c-eg20t.c  | 2 +-
 drivers/i2c/busses/i2c-elektor.c| 2 +-
 drivers/i2c/busses/i2c-gpio.c   | 2 +-
 drivers/i2c/busses/i2c-highlander.c | 2 +-
 drivers/i2c/busses/i2c-hydra.c  | 2 +-
 drivers/i2c/busses/i2c-i801.c   | 2 +-
 drivers/i2c/busses/i2c-ibm_iic.c| 2 +-
 drivers/i2c/busses/i2c-intel-mid.c  | 2 +-
 drivers/i2c/busses/i2c-isch.c   | 2 +-
 drivers/i2c/busses/i2c-mpc.c| 2 +-
 drivers/i2c/busses/i2c-mv64xxx.c| 2 +-
 drivers/i2c/busses/i2c-mxs.c| 2 +-
 drivers/i2c/busses/i2c-nforce2.c| 2 +-
 drivers/i2c/busses/i2c-nuc900.c | 2 +-
 drivers/i2c/busses/i2c-ocores.c | 2 +-
 drivers/i2c/busses/i2c-octeon.c | 2 +-
 drivers/i2c/busses/i2c-omap.c   | 2 +-
 drivers/i2c/busses/i2c-parport-light.c  | 2 +-
 drivers/i2c/busses/i2c-pasemi.c | 2 +-
 drivers/i2c/busses/i2c-pca-isa.c| 2 +-
 drivers/i2c/busses/i2c-pca-platform.c   | 2 +-
 drivers/i2c/busses/i2c-piix4.c  | 2 +-
 drivers/i2c/busses/i2c-pmcmsp.c | 2 +-
 drivers/i2c/busses/i2c-pnx.c| 2 +-
 drivers/i2c/busses/i2c-powermac.c   | 2 +-
 drivers/i2c/busses/i2c-puv3.c   | 2 +-
 drivers/i2c/busses/i2c-pxa-pci.c| 2 +-
 drivers/i2c/busses/i2c-rcar.c   | 2 +-
 drivers/i2c/busses/i2c-s6000.c  | 2 +-
 drivers/i2c/busses/i2c-sh7760.c | 2 +-
 drivers/i2c/busses/i2c-sirf.c   | 2 +-
 drivers/i2c/busses/i2c-sis630.c | 2 +-
 drivers/i2c/busses/i2c-sis96x.c | 2 +-
 drivers/i2c/busses/i2c-tegra.c  | 2 +-
 drivers/i2c/busses/i2c-via.c| 2 +-
 drivers/i2c/busses/i2c-xiic.c   | 2 +-
 drivers/i2c/busses/i2c-xlr.c| 2 +-
 drivers/i2c/busses/scx200_acb.c | 2 +-
 drivers/i2c/muxes/i2c-mux-gpio.c| 2 +-
 drivers/i2c/muxes/i2c-mux-pinctrl.c | 2 +-
 50 files changed, 50 insertions(+), 50 deletions(-)

diff --git a/drivers/i2c/busses/i2c-ali1535.c b/drivers/i2c/busses/i2c-ali1535.c
index 125cd8e..cb30432 100644
--- a/drivers/i2c/busses/i2c-ali1535.c
+++ b/drivers/i2c/busses/i2c-ali1535.c
@@ -528,7 +528,7 @@ static struct pci_driver ali1535_driver = {
.name   = ali1535_smbus,
.id_table   = ali1535_ids,
.probe  = ali1535_probe,
-   .remove = __devexit_p(ali1535_remove),
+   .remove = ali1535_remove,
 };
 
 module_pci_driver(ali1535_driver);
diff --git a/drivers/i2c/busses/i2c-ali1563.c b/drivers/i2c/busses/i2c-ali1563.c
index e02d9f8..547a96f 100644
--- a/drivers/i2c/busses/i2c-ali1563.c
+++ b/drivers/i2c/busses/i2c-ali1563.c
@@ -428,7 +428,7 @@ static struct pci_driver ali1563_pci_driver = {
.name   = ali1563_smbus,
.id_table   = ali1563_id_table,
.probe  = ali1563_probe,
-   .remove = __devexit_p(ali1563_remove),
+   .remove = ali1563_remove,
 };
 
 module_pci_driver(ali1563_pci_driver);
diff --git a/drivers/i2c/busses/i2c-ali15x3.c b/drivers/i2c/busses/i2c-ali15x3.c
index ce8d26d..62692ec 100644
--- a/drivers/i2c/busses/i2c-ali15x3.c
+++ b/drivers/i2c/busses/i2c-ali15x3.c
@@ -510,7 +510,7 @@ static struct pci_driver ali15x3_driver = {
.name   = ali15x3_smbus,
.id_table   = ali15x3_ids,
.probe  = ali15x3_probe,
-   .remove = __devexit_p(ali15x3_remove),
+   .remove = ali15x3_remove,
 };
 
 module_pci_driver(ali15x3_driver);
diff --git a/drivers/i2c/busses/i2c-amd756.c