Re: [PATCH 1/2] powerpc: Fix emulation of mcrf in emulate_step()

On 2017/06/15 09:46AM, Anton Blanchard wrote: > From: Anton Blanchard > > The mcrf emulation code was looking at the CR fields in the reverse > order. It also relied on reserved fields being zero which is somewhat > fragile, so fix that too. Yikes! Amazing catch! Acked-by:

Re: [PATCH 1/2] powerpc: Fix emulation of mcrf in emulate_step()

On Thu, Jun 15, 2017 at 04:47:29PM +1000, Anton Blanchard wrote: > > Maybe there should be (inline) > > helper function to insert/extract CR fields? > > That would be nice, there are quite a few places that could use it. Like patch 2/2, hint hint. Segher

Re: [PATCH 1/2] powerpc: Fix emulation of mcrf in emulate_step()

Hi Segher, > On Thu, Jun 15, 2017 at 09:46:38AM +1000, Anton Blanchard wrote: > > The mcrf emulation code was looking at the CR fields in the reverse > > order. It also relied on reserved fields being zero which is > > somewhat fragile, so fix that too. > > It masked out the reserved bits. I

Re: [PATCH 1/2] powerpc: Fix emulation of mcrf in emulate_step()

Hi Anton, On Thu, Jun 15, 2017 at 09:46:38AM +1000, Anton Blanchard wrote: > The mcrf emulation code was looking at the CR fields in the reverse > order. It also relied on reserved fields being zero which is somewhat > fragile, so fix that too. It masked out the reserved bits. I find the new

[PATCH 1/2] powerpc: Fix emulation of mcrf in emulate_step()

From: Anton Blanchard The mcrf emulation code was looking at the CR fields in the reverse order. It also relied on reserved fields being zero which is somewhat fragile, so fix that too. Cc: sta...@vger.kernel.org Signed-off-by: Anton Blanchard ---