Re: [PATCH 1/3] [v2] powerpc: mac: fix rtc read/write functions

2018-07-09 Thread Finn Thain
On Mon, 9 Jul 2018, Arnd Bergmann wrote: > > The most likely explanation I have here is that the RTC was indeed set > to an incorrect date, either because of a depleted battery (not unlikely > for a ~15 year old box) or because it was previously stored incorrectly. The PowerMac stores the GMT

Re: [PATCH 1/3] [v2] powerpc: mac: fix rtc read/write functions

2018-07-09 Thread Arnd Bergmann
On Sun, Jul 1, 2018 at 5:47 PM, Meelis Roos wrote: > A patch for the subject is now upstream. That made me finally take some > time to test it on my PowerMac G4. Tha date is OK but I get two warnings > with backtrace on bootup. Full dmesg below. Thanks for testing this, and sorry for the slow

Re: [PATCH 1/3] [v2] powerpc: mac: fix rtc read/write functions

2018-07-01 Thread Meelis Roos
A patch for the subject is now upstream. That made me finally take some time to test it on my PowerMac G4. Tha date is OK but I get two warnings with backtrace on bootup. Full dmesg below. [0.00] Total memory = 1024MB; using 2048kB for hash table (at (ptrval)) [0.00] RAM mapped

Re: [PATCH 1/3] [v2] powerpc: mac: fix rtc read/write functions

2018-06-27 Thread Michael Ellerman
Arnd Bergmann writes: > On Wed, Jun 27, 2018 at 6:32 AM, Michael Ellerman wrote: >> >> So I think I can take this patch in isolation via the powerpc tree as a >> fix for 4.18. >> >> I'll leave the other two alone. > > Yes, that is what I had intended with this series but should have made >

Re: [PATCH 1/3] [v2] powerpc: mac: fix rtc read/write functions

2018-06-27 Thread Arnd Bergmann
On Wed, Jun 27, 2018 at 6:32 AM, Michael Ellerman wrote: > > So I think I can take this patch in isolation via the powerpc tree as a > fix for 4.18. > > I'll leave the other two alone. > Yes, that is what I had intended with this series but should have made clearer. The two m68k patches are 4.19

Re: [PATCH 1/3] [v2] powerpc: mac: fix rtc read/write functions

2018-06-26 Thread Michael Ellerman
Arnd Bergmann writes: > As Mathieu pointed out, my conversion to time64_t was incorrect and resulted > in negative times to be read from the RTC. The problem is that during the > conversion from a byte array to a time64_t, the 'unsigned char' variable > holding the top byte gets turned into a

Re: [PATCH 1/3] [v2] powerpc: mac: fix rtc read/write functions

2018-06-20 Thread Mathieu Malaterre
On Tue, Jun 19, 2018 at 4:04 PM Arnd Bergmann wrote: > > As Mathieu pointed out, my conversion to time64_t was incorrect and resulted > in negative times to be read from the RTC. The problem is that during the > conversion from a byte array to a time64_t, the 'unsigned char' variable > holding

[PATCH 1/3] [v2] powerpc: mac: fix rtc read/write functions

2018-06-19 Thread Arnd Bergmann
As Mathieu pointed out, my conversion to time64_t was incorrect and resulted in negative times to be read from the RTC. The problem is that during the conversion from a byte array to a time64_t, the 'unsigned char' variable holding the top byte gets turned into a negative signed 32-bit integer