Re: [PATCH 1/3] Makefile: Include arch Makefiles as late as possible

2009-02-16 Thread Anton Vorontsov
On Sat, Feb 14, 2009 at 08:57:02PM +0100, Sam Ravnborg wrote: [...] --- a/Makefile +++ b/Makefile @@ -525,8 +525,6 @@ else KBUILD_CFLAGS+= -O2 endif -include $(srctree)/arch/$(SRCARCH)/Makefile - ifneq (CONFIG_FRAME_WARN,0) KBUILD_CFLAGS += $(call

Re: [PATCH 1/3] Makefile: Include arch Makefiles as late as possible

2009-02-16 Thread Anton Vorontsov
On Mon, Feb 16, 2009 at 05:20:01PM +0300, Anton Vorontsov wrote: On Sat, Feb 14, 2009 at 08:57:02PM +0100, Sam Ravnborg wrote: [...] --- a/Makefile +++ b/Makefile @@ -525,8 +525,6 @@ else KBUILD_CFLAGS += -O2 endif -include $(srctree)/arch/$(SRCARCH)/Makefile

Re: [PATCH 1/3] Makefile: Include arch Makefiles as late as possible

2009-02-16 Thread Anton Vorontsov
On Mon, Feb 16, 2009 at 05:20:01PM +0300, Anton Vorontsov wrote: [...] But then, this commit reverted things back (w/o your Ack): commit bef5b54bd7bf8117c75cb943d64549134c6d9a1f Author: Ralf Baechle r...@linux-mips.org Date: Wed Jul 16 13:02:24 2008 +0100 Fix MIPS cross-compile

Re: [PATCH 1/3] Makefile: Include arch Makefiles as late as possible

2009-02-16 Thread Ingo Molnar
* Anton Vorontsov avoront...@ru.mvista.com wrote: On Mon, Feb 16, 2009 at 05:20:01PM +0300, Anton Vorontsov wrote: [...] But then, this commit reverted things back (w/o your Ack): commit bef5b54bd7bf8117c75cb943d64549134c6d9a1f Author: Ralf Baechle r...@linux-mips.org Date: Wed

Re: [PATCH 1/3] Makefile: Include arch Makefiles as late as possible

2009-02-16 Thread Sam Ravnborg
There are few arches that have auto detection of CROSS_COMPILE variable: mips, m68k, parisc, xtensa, h8300 and blackfin. So `normal' arches don't have any chance to overwrite the flags because of the few offenders above. ;-) We also have archs where we add options to gcc that may impact

Re: [PATCH 1/3] Makefile: Include arch Makefiles as late as possible

2009-02-15 Thread Ingo Molnar
* Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Sat, 2009-02-14 at 23:03 +0100, Ingo Molnar wrote: So the question is: even with FRAME_POINTERS disabled on PPC, is __builtin_return_address(1)/(2) reliable, and is save_stack_trace() fast? (i.e. can it walk down the stack

Re: [PATCH 1/3] Makefile: Include arch Makefiles as late as possible

2009-02-14 Thread Sam Ravnborg
On Wed, Feb 04, 2009 at 10:26:12PM +0100, Ingo Molnar wrote: * Anton Vorontsov avoront...@ru.mvista.com wrote: This patch gives arches more freedom on overwriting CFLAGS, specifically on PowerPC we want to remove -fno-omit-frame-pointer flag. Signed-off-by: Anton Vorontsov

Re: [PATCH 1/3] Makefile: Include arch Makefiles as late as possible

2009-02-14 Thread Sam Ravnborg
On Wed, Feb 11, 2009 at 02:51:34PM +1100, Benjamin Herrenschmidt wrote: On Wed, 2009-02-04 at 22:26 +0100, Ingo Molnar wrote: +include $(srctree)/arch/$(SRCARCH)/Makefile + # arch Makefile may override CC so keep this after arch Makefile is included NOSTDINC_FLAGS += -nostdinc

Re: [PATCH 1/3] Makefile: Include arch Makefiles as late as possible

2009-02-14 Thread Ingo Molnar
* Sam Ravnborg s...@ravnborg.org wrote: On Wed, Feb 04, 2009 at 10:26:12PM +0100, Ingo Molnar wrote: * Anton Vorontsov avoront...@ru.mvista.com wrote: This patch gives arches more freedom on overwriting CFLAGS, specifically on PowerPC we want to remove -fno-omit-frame-pointer

Re: [PATCH 1/3] Makefile: Include arch Makefiles as late as possible

2009-02-14 Thread Benjamin Herrenschmidt
On Sat, 2009-02-14 at 23:03 +0100, Ingo Molnar wrote: So the question is: even with FRAME_POINTERS disabled on PPC, is __builtin_return_address(1)/(2) reliable, and is save_stack_trace() fast? (i.e. can it walk down the stack frame efficiently, or does it have to scan the full kernel

Re: [PATCH 1/3] Makefile: Include arch Makefiles as late as possible

2009-02-11 Thread Steven Rostedt
On Wed, 2009-02-11 at 14:23 +0100, Ingo Molnar wrote: * Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Wed, 2009-02-04 at 22:26 +0100, Ingo Molnar wrote: +include $(srctree)/arch/$(SRCARCH)/Makefile + # arch Makefile may override CC so keep this after arch Makefile is

Re: [PATCH 1/3] Makefile: Include arch Makefiles as late as possible

2009-02-10 Thread Benjamin Herrenschmidt
On Wed, 2009-02-04 at 22:26 +0100, Ingo Molnar wrote: +include $(srctree)/arch/$(SRCARCH)/Makefile + # arch Makefile may override CC so keep this after arch Makefile is included NOSTDINC_FLAGS += -nostdinc -isystem $(shell $(CC) -print-file-name=include) CHECKFLAGS +=

[PATCH 1/3] Makefile: Include arch Makefiles as late as possible

2009-02-04 Thread Anton Vorontsov
This patch gives arches more freedom on overwriting CFLAGS, specifically on PowerPC we want to remove -fno-omit-frame-pointer flag. Signed-off-by: Anton Vorontsov avoront...@ru.mvista.com --- Makefile |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile