Re: [PATCH 1/3] kbuild: add macro for controlling warnings to linux/compiler.h

2018-06-20 Thread Paul Burton
Hi Masahiro, On Thu, Jun 21, 2018 at 08:21:01AM +0900, Masahiro Yamada wrote: > V2 is good except one nit. > (I left a comment in it) Thanks, and yes I agree with your comment that the GCC<4.6 __diag() definition can be removed. > I can fix it up locally if it is tedious to re-spin, though. If

Re: [PATCH 1/3] kbuild: add macro for controlling warnings to linux/compiler.h

2018-06-20 Thread Masahiro Yamada
2018-06-20 4:02 GMT+09:00 Paul Burton : > Hi Masahiro, > > On Wed, Jun 20, 2018 at 02:34:35AM +0900, Masahiro Yamada wrote: >> 2018-06-16 9:53 GMT+09:00 Paul Burton : >> > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h >> > index f1a7492a5cc8..aba64a2912d8 100644 >> > ---

Re: [PATCH 1/3] kbuild: add macro for controlling warnings to linux/compiler.h

2018-06-19 Thread Paul Burton
Hi Masahiro, On Wed, Jun 20, 2018 at 02:34:35AM +0900, Masahiro Yamada wrote: > 2018-06-16 9:53 GMT+09:00 Paul Burton : > > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h > > index f1a7492a5cc8..aba64a2912d8 100644 > > --- a/include/linux/compiler-gcc.h > > +++

Re: [PATCH 1/3] kbuild: add macro for controlling warnings to linux/compiler.h

2018-06-19 Thread Masahiro Yamada
Hi. 2018-06-16 9:53 GMT+09:00 Paul Burton : > From: Arnd Bergmann > > I have occasionally run into a situation where it would make sense to > control a compiler warning from a source file rather than doing so from > a Makefile using the $(cc-disable-warning, ...) or $(cc-option, ...) > helpers.

Re: [PATCH 1/3] kbuild: add macro for controlling warnings to linux/compiler.h

2018-06-18 Thread Christophe LEROY
Le 16/06/2018 à 02:53, Paul Burton a écrit : From: Arnd Bergmann I have occasionally run into a situation where it would make sense to control a compiler warning from a source file rather than doing so from a Makefile using the $(cc-disable-warning, ...) or $(cc-option, ...) helpers. The

[PATCH 1/3] kbuild: add macro for controlling warnings to linux/compiler.h

2018-06-15 Thread Paul Burton
From: Arnd Bergmann I have occasionally run into a situation where it would make sense to control a compiler warning from a source file rather than doing so from a Makefile using the $(cc-disable-warning, ...) or $(cc-option, ...) helpers. The approach here is similar to what glibc uses, using