Re: [PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh

2023-11-08 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 07, 2023 at 12:08:25PM +0530, Athira Rajeev escreveu: > > On 07-Nov-2023, at 3:14 AM, Arnaldo Carvalho de Melo > > wrote: > >>> Reviewed-by: James Clark > > Some are not applying, even after b4 picking up v2 > > Total patches: 3 > > Cover: > >

Re: [PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh

2023-11-06 Thread Athira Rajeev
> On 07-Nov-2023, at 3:14 AM, Arnaldo Carvalho de Melo wrote: > > Em Thu, Oct 05, 2023 at 02:24:15PM +0530, Athira Rajeev escreveu: >>> On 05-Oct-2023, at 1:50 PM, James Clark wrote: >>> On 29/09/2023 05:11, Athira Rajeev wrote: Running shellcheck on tests/shell/test_arm_coresight.sh

Re: [PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh

2023-11-06 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 05, 2023 at 02:24:15PM +0530, Athira Rajeev escreveu: > > On 05-Oct-2023, at 1:50 PM, James Clark wrote: > > On 29/09/2023 05:11, Athira Rajeev wrote: > >> Running shellcheck on tests/shell/test_arm_coresight.sh > >> throws below warnings: > >> > >> In

Re: [PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh

2023-10-12 Thread Athira Rajeev
> On 12-Oct-2023, at 9:37 PM, Suzuki K Poulose wrote: > > Hi, > > On 12/10/2023 16:56, Athira Rajeev wrote: >>> On 05-Oct-2023, at 3:06 PM, Suzuki K Poulose wrote: >>> >>> On 05/10/2023 06:02, Namhyung Kim wrote: On Thu, Sep 28, 2023 at 9:11 PM Athira Rajeev wrote: > > >

Re: [PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh

2023-10-12 Thread Suzuki K Poulose
Hi, On 12/10/2023 16:56, Athira Rajeev wrote: On 05-Oct-2023, at 3:06 PM, Suzuki K Poulose wrote: On 05/10/2023 06:02, Namhyung Kim wrote: On Thu, Sep 28, 2023 at 9:11 PM Athira Rajeev wrote: ... Thanks for the fix. Nothing to do with this patch, but I am wondering if the original

Re: [PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh

2023-10-12 Thread Athira Rajeev
> On 05-Oct-2023, at 3:06 PM, Suzuki K Poulose wrote: > > On 05/10/2023 06:02, Namhyung Kim wrote: >> On Thu, Sep 28, 2023 at 9:11 PM Athira Rajeev >> wrote: >>> >>> Running shellcheck on tests/shell/test_arm_coresight.sh >>> throws below warnings: >>> >>> In

Re: [PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh

2023-10-12 Thread Athira Rajeev
> On 05-Oct-2023, at 9:15 PM, David Laight wrote: > > From: David Laight >> Sent: 05 October 2023 11:16 > ... >>> - cs_etm_path=$(find /sys/bus/event_source/devices/cs_etm/ -name cpu* >>> -print -quit) >>> + cs_etm_path=$(find /sys/bus/event_source/devices/cs_etm/ -name 'cpu*' >>> -print

RE: [PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh

2023-10-05 Thread David Laight
From: David Laight > Sent: 05 October 2023 11:16 ... > > - cs_etm_path=$(find /sys/bus/event_source/devices/cs_etm/ -name cpu* > > -print -quit) > > + cs_etm_path=$(find /sys/bus/event_source/devices/cs_etm/ -name 'cpu*' > > -print -quit) > > Isn't the intention to get the shell to expand

Re: [PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh

2023-10-05 Thread Athira Rajeev
> On 05-Oct-2023, at 1:50 PM, James Clark wrote: > > > > On 29/09/2023 05:11, Athira Rajeev wrote: >> Running shellcheck on tests/shell/test_arm_coresight.sh >> throws below warnings: >> >> In tests/shell/test_arm_coresight.sh line 15: >> cs_etm_path=$(find

RE: [PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh

2023-10-05 Thread David Laight
From: Athira Rajeev > Sent: 29 September 2023 05:12 > > Running shellcheck on tests/shell/test_arm_coresight.sh > throws below warnings: > > In tests/shell/test_arm_coresight.sh line 15: > cs_etm_path=$(find /sys/bus/event_source/devices/cs_etm/ -name cpu* > -print -quit) >

Re: [PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh

2023-10-05 Thread Suzuki K Poulose
On 05/10/2023 06:02, Namhyung Kim wrote: On Thu, Sep 28, 2023 at 9:11 PM Athira Rajeev wrote: Running shellcheck on tests/shell/test_arm_coresight.sh throws below warnings: In tests/shell/test_arm_coresight.sh line 15: cs_etm_path=$(find

Re: [PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh

2023-10-05 Thread James Clark
On 29/09/2023 05:11, Athira Rajeev wrote: > Running shellcheck on tests/shell/test_arm_coresight.sh > throws below warnings: > > In tests/shell/test_arm_coresight.sh line 15: > cs_etm_path=$(find /sys/bus/event_source/devices/cs_etm/ -name cpu* > -print -quit) >

Re: [PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh

2023-10-05 Thread James Clark
On 05/10/2023 06:02, Namhyung Kim wrote: > On Thu, Sep 28, 2023 at 9:11 PM Athira Rajeev > wrote: >> >> Running shellcheck on tests/shell/test_arm_coresight.sh >> throws below warnings: >> >> In tests/shell/test_arm_coresight.sh line 15: >> cs_etm_path=$(find

Re: [PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh

2023-10-04 Thread Namhyung Kim
On Thu, Sep 28, 2023 at 9:11 PM Athira Rajeev wrote: > > Running shellcheck on tests/shell/test_arm_coresight.sh > throws below warnings: > > In tests/shell/test_arm_coresight.sh line 15: > cs_etm_path=$(find /sys/bus/event_source/devices/cs_etm/ -name cpu* > -print -quit) >

[PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh

2023-09-28 Thread Athira Rajeev
Running shellcheck on tests/shell/test_arm_coresight.sh throws below warnings: In tests/shell/test_arm_coresight.sh line 15: cs_etm_path=$(find /sys/bus/event_source/devices/cs_etm/ -name cpu* -print -quit) ^--^ SC2061: Quote the parameter to -name so the shell