Re: [PATCH 1/4] powerpc/pseries/iommu: Update call to ibm,query-pe-dma-windows

2020-06-22 Thread Alexey Kardashevskiy
On 23/06/2020 12:14, Leonardo Bras wrote: > On Tue, 2020-06-23 at 11:12 +1000, Alexey Kardashevskiy wrote: > [snip] > +static int query_ddw_out_sz(struct device_node *par_dn) Can easily be folded into query_ddw(). >>> >>> Sure, but it will get inlined by the compiler, and I think

Re: [PATCH 1/4] powerpc/pseries/iommu: Update call to ibm,query-pe-dma-windows

2020-06-22 Thread Leonardo Bras
On Tue, 2020-06-23 at 11:12 +1000, Alexey Kardashevskiy wrote: [snip] > > > > +static int query_ddw_out_sz(struct device_node *par_dn) > > > > > > Can easily be folded into query_ddw(). > > > > Sure, but it will get inlined by the compiler, and I think it reads > > better this way. > > I mean,

Re: [PATCH 1/4] powerpc/pseries/iommu: Update call to ibm,query-pe-dma-windows

2020-06-22 Thread Alexey Kardashevskiy
On 23/06/2020 04:58, Leonardo Bras wrote: > Hello Alexey, thank you for the feedback! > > On Mon, 2020-06-22 at 20:02 +1000, Alexey Kardashevskiy wrote: >> >> On 19/06/2020 15:06, Leonardo Bras wrote: >>> From LoPAR level 2.8, "ibm,ddw-extensions" index 3 can make the number of >>> outputs

Re: [PATCH 1/4] powerpc/pseries/iommu: Update call to ibm,query-pe-dma-windows

2020-06-22 Thread Leonardo Bras
Hello Alexey, thank you for the feedback! On Mon, 2020-06-22 at 20:02 +1000, Alexey Kardashevskiy wrote: > > On 19/06/2020 15:06, Leonardo Bras wrote: > > From LoPAR level 2.8, "ibm,ddw-extensions" index 3 can make the number of > > outputs from "ibm,query-pe-dma-windows" go from 5 to 6. > > >

Re: [PATCH 1/4] powerpc/pseries/iommu: Update call to ibm,query-pe-dma-windows

2020-06-22 Thread Alexey Kardashevskiy
On 19/06/2020 15:06, Leonardo Bras wrote: > From LoPAR level 2.8, "ibm,ddw-extensions" index 3 can make the number of > outputs from "ibm,query-pe-dma-windows" go from 5 to 6. > > This change of output size is meant to expand the address size of > largest_available_block PE TCE from 32-bit to

[PATCH 1/4] powerpc/pseries/iommu: Update call to ibm, query-pe-dma-windows

2020-06-18 Thread Leonardo Bras
>From LoPAR level 2.8, "ibm,ddw-extensions" index 3 can make the number of outputs from "ibm,query-pe-dma-windows" go from 5 to 6. This change of output size is meant to expand the address size of largest_available_block PE TCE from 32-bit to 64-bit, which ends up shifting page_size and