Re: [PATCH 1/9] macintosh/via-macii: Access autopoll_devs when inside lock

2020-08-09 Thread Finn Thain
On Sun, 9 Aug 2020, Guenter Roeck wrote: > Hi, > > On Sun, Jun 28, 2020 at 02:23:12PM +1000, Finn Thain wrote: > > The interrupt handler should be excluded when accessing the > > autopoll_devs variable. > > > > I am quite baffled by this patch. Other than adding an unnecessary lock > /

Re: [PATCH 1/9] macintosh/via-macii: Access autopoll_devs when inside lock

2020-08-09 Thread Guenter Roeck
Hi, On Sun, Jun 28, 2020 at 02:23:12PM +1000, Finn Thain wrote: > The interrupt handler should be excluded when accessing the autopoll_devs > variable. > I am quite baffled by this patch. Other than adding an unnecessary lock / unlock sequence, accessing a variable (which is derived from

[PATCH 1/9] macintosh/via-macii: Access autopoll_devs when inside lock

2020-06-27 Thread Finn Thain
The interrupt handler should be excluded when accessing the autopoll_devs variable. Fixes: d95fd5fce88f0 ("m68k: Mac II ADB fixes") # v5.0+ Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/macintosh/via-macii.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff