Re: [PATCH 10/10] IB/ehca: Support large page MRs

2007-07-16 Thread Roland Dreier 
  Add support for MR pages larger than 4K on eHCA2. This reduces firmware
  memory consumption. If enabled via the mr_largepage module parameter, the MR
  page size will be determined based on the MR length and the hardware
  capabilities - if the MR is = 16M, 16M pages are used, for example.

Why the module parameter?  Is there any reason a user would want to
turn this off?  Or conversely, why is it off by default?

Also this patch seems to depend heavily on the multiple EQ patch,
which I am holding off on now.  So you may want to rebase to my
current tree, which has all the ehca patches except the EQ one.

   static ssize_t ehca_show_nr_eqs(struct device *dev,
   struct device_attribute *attr,
   char *buf)
   {
   return sprintf(buf, %d\n, ehca_nr_eqs);
   }
  -
   static DEVICE_ATTR(nr_eqs, S_IRUGO, ehca_show_nr_eqs, NULL);

Although trivial, this chunk doesn't really belong in this patch --
just fix it up in the multiple EQ patch (which I haven't merged yet).

 - R.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 10/10] IB/ehca: Support large page MRs

2007-07-16 Thread Joachim Fenkes 
Roland Dreier [EMAIL PROTECTED] wrote on 16.07.2007 19:37:09:

   If enabled via the mr_largepage module parameter, 
 
 Why the module parameter?  Is there any reason a user would want to
 turn this off?  Or conversely, why is it off by default?

We're pretty confident this new feature works, but as with all new and 
possibly experimental features, there are chances it might explode your 
machine when activated. So, like with the scaling code, we want the user 
to make the conscious decision of using this code instead of activating it 
by default.
 
static ssize_t ehca_show_nr_eqs(struct device *dev,
struct device_attribute *attr,
char *buf)
{
   return sprintf(buf, %d\n, ehca_nr_eqs);
}
   -
static DEVICE_ATTR(nr_eqs, S_IRUGO, ehca_show_nr_eqs, NULL);
 
 Although trivial, this chunk doesn't really belong in this patch --
 just fix it up in the multiple EQ patch (which I haven't merged yet).

Sure thing.

Regards,
  Joachim
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 10/10] IB/ehca: Support large page MRs

2007-07-16 Thread Roland Dreier 
   Why the module parameter?  Is there any reason a user would want to
   turn this off?  Or conversely, why is it off by default?
  
  We're pretty confident this new feature works, but as with all new and 
  possibly experimental features, there are chances it might explode your 
  machine when activated. So, like with the scaling code, we want the user 
  to make the conscious decision of using this code instead of activating it 
  by default.

OK, I guess.  So can we expect to, say, change the default to turning
it on for 2.6.24 and remove the option entirely (so it's always on) in
2.6.25?

 - R.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev