Re: [PATCH 12/40] x86, compat: convert ia32 layer to use

2010-06-24 Thread Christoph Hellwig
On Wed, Jun 23, 2010 at 12:23:44PM -0700, H. Peter Anvin wrote: arch/s390/kernel/sys_s390.c:SYSCALL_DEFINE(s390_fallocate)(int fd, int mode, loff_t offset, arch/sparc/kernel/sys_sparc_64.c:SYSCALL_DEFINE1(sparc_pipe_real, struct pt_regs *, regs) In fact we sort of wanted to

[PATCH 12/40] x86, compat: convert ia32 layer to use

2010-06-23 Thread Ian Munsie
From: Jason Baron jba...@redhat.com Make use of the new ARCH_COMPAT_SYSCALL_DEFINE#N() macros to tie the compat syscalls into the event tracer. Signed-off-by: Jason Baron jba...@redhat.com Signed-off-by: Ian Munsie imun...@au1.ibm.com --- arch/x86/ia32/sys_ia32.c | 102

Re: [PATCH 12/40] x86, compat: convert ia32 layer to use

2010-06-23 Thread Christoph Hellwig
Any reason we need to differenciate between COMPAT_SYSCALL_DEFINE and ARCH_COMPAT_SYSCALL_DEFINE? We don't need this for native system calls, so I can't see the reason to do it for compat system calls. ___ Linuxppc-dev mailing list

Re: [PATCH 12/40] x86, compat: convert ia32 layer to use

2010-06-23 Thread Frederic Weisbecker
On Wed, Jun 23, 2010 at 12:14:02PM +0200, Christoph Hellwig wrote: Any reason we need to differenciate between COMPAT_SYSCALL_DEFINE and ARCH_COMPAT_SYSCALL_DEFINE? We don't need this for native system calls, so I can't see the reason to do it for compat system calls. I think we wanted

Re: [PATCH 12/40] x86, compat: convert ia32 layer to use

2010-06-23 Thread Christoph Hellwig
On Wed, Jun 23, 2010 at 12:36:21PM +0200, Frederic Weisbecker wrote: I think we wanted that to keep the sys32_ prefixed based naming, to avoid collisions with generic compat handler names. For native syscalls we do this by adding a arch prefix inside the syscall name, e.g.:

Re: [PATCH 12/40] x86, compat: convert ia32 layer to use

2010-06-23 Thread Frederic Weisbecker
On Wed, Jun 23, 2010 at 12:46:04PM +0200, Christoph Hellwig wrote: On Wed, Jun 23, 2010 at 12:36:21PM +0200, Frederic Weisbecker wrote: I think we wanted that to keep the sys32_ prefixed based naming, to avoid collisions with generic compat handler names. For native syscalls we do this by

Re: [PATCH 12/40] x86, compat: convert ia32 layer to use

2010-06-23 Thread H. Peter Anvin
On 06/23/2010 04:41 AM, Frederic Weisbecker wrote: On Wed, Jun 23, 2010 at 12:46:04PM +0200, Christoph Hellwig wrote: On Wed, Jun 23, 2010 at 12:36:21PM +0200, Frederic Weisbecker wrote: I think we wanted that to keep the sys32_ prefixed based naming, to avoid collisions with generic compat