Re: [PATCH 2/2] mm: THP page cache support for ppc64

2016-11-11 Thread Hugh Dickins
On Fri, 11 Nov 2016, Kirill A. Shutemov wrote: > On Fri, Nov 11, 2016 at 05:42:11PM +0530, Aneesh Kumar K.V wrote: > > > > doing this in do_set_pmd keeps this closer to where we set the pmd. Any > > reason you thing we should move it higher up the stack. We already do > > pte_alloc() at the same

Re: [PATCH 2/2] mm: THP page cache support for ppc64

2016-11-11 Thread Kirill A. Shutemov
On Fri, Nov 11, 2016 at 05:42:11PM +0530, Aneesh Kumar K.V wrote: > "Kirill A. Shutemov" writes: > > > On Mon, Nov 07, 2016 at 02:04:41PM +0530, Aneesh Kumar K.V wrote: > >> @@ -2953,6 +2966,13 @@ static int do_set_pmd(struct fault_env *fe, struct > >> page *page) > >>

Re: [PATCH 2/2] mm: THP page cache support for ppc64

2016-11-11 Thread Aneesh Kumar K.V
"Kirill A. Shutemov" writes: > On Mon, Nov 07, 2016 at 02:04:41PM +0530, Aneesh Kumar K.V wrote: >> @@ -2953,6 +2966,13 @@ static int do_set_pmd(struct fault_env *fe, struct >> page *page) >> ret = VM_FAULT_FALLBACK; >> page = compound_head(page); >> >> +/*

Re: [PATCH 2/2] mm: THP page cache support for ppc64

2016-11-11 Thread Kirill A. Shutemov
On Mon, Nov 07, 2016 at 02:04:41PM +0530, Aneesh Kumar K.V wrote: > @@ -2953,6 +2966,13 @@ static int do_set_pmd(struct fault_env *fe, struct > page *page) > ret = VM_FAULT_FALLBACK; > page = compound_head(page); > > + /* > + * Archs like ppc64 need additonal space to store

[PATCH 2/2] mm: THP page cache support for ppc64

2016-11-07 Thread Aneesh Kumar K.V
Add arch specific callback in the generic THP page cache code that will deposit and withdarw preallocated page table. Archs like ppc64 use this preallocated table to store the hash pte slot information. Testing: kernel build of the patch series on tmpfs mounted with option huge=always The