Re: [PATCH 2/2] powerpc, ftrace: use create_branch lib function

2009-02-14 Thread Steven Rostedt
On Sun, 15 Feb 2009, Michael Ellerman wrote: > > > > /* if (link) set op to 'bl' else 'b' */ > > - op = 0x4800 | (link ? 1 : 0); > > - op |= (ftrace_calc_offset(ip, addr) & 0x03fc); > > + op = create_branch((unsigned int *)ip, addr, link ? 1 : 0); > > If I was feeling nit-pic

Re: [PATCH 2/2] powerpc, ftrace: use create_branch lib function

2009-02-14 Thread Michael Ellerman
On Fri, 2009-02-13 at 10:00 -0500, Steven Rostedt wrote: > plain text document attachment > (0002-powerpc-ftrace-use-create_branch-lib-function.patch) > From: Steven Rostedt > > Impact: clean up, remove duplicate code > > When ftrace was first ported to PowerPC, there existed a > create_function

[PATCH 2/2] powerpc, ftrace: use create_branch lib function

2009-02-13 Thread Steven Rostedt
From: Steven Rostedt Impact: clean up, remove duplicate code When ftrace was first ported to PowerPC, there existed a create_function_call that would create the instruction to make a call to a given address. Unfortunately, this call expected to write to the address it was given, and since it use