Running shellcheck on lock_contention.sh generates below
warning

        In tests/shell/lock_contention.sh line 36:
           if [ `nproc` -lt 4 ]; then
                  ^-----^ SC2046: Quote this to prevent word splitting.

Here since nproc will generate a single word output
and there is no possibility of word splitting, this
warning can be ignored. Use exception for this with
"disable" option in shellcheck. This warning is observed
after commit:
"commit 29441ab3a30a ("perf test lock_contention.sh: Skip test
if not enough CPUs")"

Fixes: 29441ab3a30a ("perf test lock_contention.sh: Skip test if not enough 
CPUs")
Signed-off-by: Athira Rajeev <atraj...@linux.vnet.ibm.com>
---
 tools/perf/tests/shell/lock_contention.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/tests/shell/lock_contention.sh 
b/tools/perf/tests/shell/lock_contention.sh
index d5a191d3d090..c1ec5762215b 100755
--- a/tools/perf/tests/shell/lock_contention.sh
+++ b/tools/perf/tests/shell/lock_contention.sh
@@ -33,6 +33,7 @@ check() {
                exit
        fi
 
+       # shellcheck disable=SC2046
        if [ `nproc` -lt 4 ]; then
                echo "[Skip] Low number of CPUs (`nproc`), lock event cannot be 
triggered certainly"
                err=2
-- 
2.31.1

Reply via email to