Re: [PATCH 2/5] ocxl: Clean up printf formats

2019-03-13 Thread Andrew Donnellan
On 13/3/19 3:06 pm, Alastair D'Silva wrote: From: Alastair D'Silva Use %# instead of using a literal '0x' Signed-off-by: Alastair D'Silva Acked-by: Andrew Donnellan --- drivers/misc/ocxl/config.c | 6 +++--- drivers/misc/ocxl/context.c | 2 +- drivers/misc/ocxl/trace.h | 10

Re: [PATCH 2/5] ocxl: Clean up printf formats

2019-03-13 Thread Greg Kurz
On Wed, 13 Mar 2019 15:06:58 +1100 "Alastair D'Silva" wrote: > From: Alastair D'Silva > > Use %# instead of using a literal '0x' > > Signed-off-by: Alastair D'Silva > --- Reviewed-by: Greg Kurz > drivers/misc/ocxl/config.c | 6 +++--- > drivers/misc/ocxl/context.c | 2 +- >

[PATCH 2/5] ocxl: Clean up printf formats

2019-03-12 Thread Alastair D'Silva
From: Alastair D'Silva Use %# instead of using a literal '0x' Signed-off-by: Alastair D'Silva --- drivers/misc/ocxl/config.c | 6 +++--- drivers/misc/ocxl/context.c | 2 +- drivers/misc/ocxl/trace.h | 10 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git

Re: [PATCH 2/5] ocxl: Clean up printf formats

2019-03-01 Thread Joe Perches
On Wed, 2019-02-27 at 15:57 +1100, Alastair D'Silva wrote: > From: Alastair D'Silva > > Use %# instead of using a literal '0x' I think it's better not to change this unless the compilation unit already uses a mix of styles. Overall, the kernel uses "0x%" over "%#" by ~8:1 $ git grep -P

Re: [PATCH 2/5] ocxl: Clean up printf formats

2019-02-27 Thread Andrew Donnellan
On 27/2/19 3:57 pm, Alastair D'Silva wrote: From: Alastair D'Silva Use %# instead of using a literal '0x' Signed-off-by: Alastair D'Silva Not hugely fussed either way, but today I learned about %#... Acked-by: Andrew Donnellan --- drivers/misc/ocxl/config.c | 6 +++---

Re: [PATCH 2/5] ocxl: Clean up printf formats

2019-02-27 Thread Frederic Barrat
Le 27/02/2019 à 05:57, Alastair D'Silva a écrit : From: Alastair D'Silva Use %# instead of using a literal '0x' Signed-off-by: Alastair D'Silva --- I don't really care either way, but it looks ok. Acked-by: Frederic Barrat drivers/misc/ocxl/config.c | 6 +++---

[PATCH 2/5] ocxl: Clean up printf formats

2019-02-26 Thread Alastair D'Silva
From: Alastair D'Silva Use %# instead of using a literal '0x' Signed-off-by: Alastair D'Silva --- drivers/misc/ocxl/config.c | 6 +++--- drivers/misc/ocxl/context.c | 2 +- drivers/misc/ocxl/trace.h | 10 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git