Re: [PATCH 2/8] leds: nic78bx: explicitly unregister LEDs at module's shutdown

2023-11-09 Thread George Stark
Hello Christophe. Thanks for the review. On 11/6/23 11:13, Christophe Leroy wrote: > > > Le 25/10/2023 à 15:07, George Stark a écrit : >> LEDs are registered using devm_led_classdev_register() and automatically >> unregistered after module's remove(). led_classdev_unregister() calls >>

Re: [PATCH 2/8] leds: nic78bx: explicitly unregister LEDs at module's shutdown

2023-11-06 Thread Christophe Leroy
Le 25/10/2023 à 15:07, George Stark a écrit : > LEDs are registered using devm_led_classdev_register() and automatically > unregistered after module's remove(). led_classdev_unregister() calls > led_set_brightness() to turn off the LEDs and module's appropriate callback > uses resources those

[PATCH 2/8] leds: nic78bx: explicitly unregister LEDs at module's shutdown

2023-10-25 Thread George Stark
LEDs are registered using devm_led_classdev_register() and automatically unregistered after module's remove(). led_classdev_unregister() calls led_set_brightness() to turn off the LEDs and module's appropriate callback uses resources those were destroyed already in module's remove(). So explicitly