Re: [PATCH 28/28] s390: use __vmalloc_node in stack_alloc

[Christian Borntraeger]

On 08.04.20 13:59, Christoph Hellwig wrote:
> stack_alloc can use a slightly higher level vmalloc function.
> 
> Signed-off-by: Christoph Hellwig 
> ---
>  arch/s390/kernel/setup.c | 9 +++--
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/s390/kernel/setup.c b/arch/s390/kernel/setup.c
> index 36445dd40fdb..0f0b140b5558 100644
> --- a/arch/s390/kernel/setup.c
> +++ b/arch/s390/kernel/setup.c
> @@ -305,12 +305,9 @@ void *restart_stack __section(.data);
>  unsigned long stack_alloc(void)
>  {
>  #ifdef CONFIG_VMAP_STACK
> - return (unsigned long)
> - __vmalloc_node_range(THREAD_SIZE, THREAD_SIZE,
> -  VMALLOC_START, VMALLOC_END,
> -  THREADINFO_GFP,
> -  PAGE_KERNEL, 0, NUMA_NO_NODE,
> -  __builtin_return_address(0));
> + return (unsigned long)__vmalloc_node(THREAD_SIZE, THREAD_SIZE,
> + THREADINFO_GFP, NUMA_NO_NODE,
> + __builtin_return_address(0));

Looks sane.

Acked-by: Christian Borntraeger 


>  #else
>   return __get_free_pages(GFP_KERNEL, THREAD_SIZE_ORDER);
>  #endif
> 

[PATCH 28/28] s390: use __vmalloc_node in stack_alloc

[Christoph Hellwig]

stack_alloc can use a slightly higher level vmalloc function.

Signed-off-by: Christoph Hellwig 
---
 arch/s390/kernel/setup.c | 9 +++--
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/s390/kernel/setup.c b/arch/s390/kernel/setup.c
index 36445dd40fdb..0f0b140b5558 100644
--- a/arch/s390/kernel/setup.c
+++ b/arch/s390/kernel/setup.c
@@ -305,12 +305,9 @@ void *restart_stack __section(.data);
 unsigned long stack_alloc(void)
 {
 #ifdef CONFIG_VMAP_STACK
-   return (unsigned long)
-   __vmalloc_node_range(THREAD_SIZE, THREAD_SIZE,
-VMALLOC_START, VMALLOC_END,
-THREADINFO_GFP,
-PAGE_KERNEL, 0, NUMA_NO_NODE,
-__builtin_return_address(0));
+   return (unsigned long)__vmalloc_node(THREAD_SIZE, THREAD_SIZE,
+   THREADINFO_GFP, NUMA_NO_NODE,
+   __builtin_return_address(0));
 #else
return __get_free_pages(GFP_KERNEL, THREAD_SIZE_ORDER);
 #endif
-- 
2.25.1